Move insecure cluster service and delete securityOss plugin

The securityOss plugin provided an insecure cluster service that the security plugin augmented using its own security checkup service. I combined the two into the latter. That was the last dependency on the securityOss plugin, so this allowed me to completely remove the plugin.
elastic · Oct 5, 2021 · 126d1fb · 126d1fb
1 parent bbb5d3a
commit 126d1fb
Show file tree

Hide file tree

Showing 62 changed files with 537 additions and 1,706 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1595,7 +1595,6 @@ module.exports = {
      */
     {
       files: [
-        'src/plugins/security_oss/**/*.{js,mjs,ts,tsx}',
         'src/plugins/interactive_setup/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/encrypted_saved_objects/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/security/**/*.{js,mjs,ts,tsx}',

diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -287,7 +287,6 @@
 
 # Security
 /src/core/server/csp/ @elastic/kibana-security @elastic/kibana-core
-/src/plugins/security_oss/ @elastic/kibana-security
 /src/plugins/interactive_setup/ @elastic/kibana-security
 /test/security_functional/ @elastic/kibana-security
 /x-pack/plugins/spaces/ @elastic/kibana-security

diff --git a/.i18nrc.json b/.i18nrc.json
@@ -53,7 +53,6 @@
     "newsfeed": "src/plugins/newsfeed",
     "savedObjects": "src/plugins/saved_objects",
     "savedObjectsManagement": "src/plugins/saved_objects_management",
-    "security": "src/plugins/security_oss",
     "server": "src/legacy/server",
     "statusPage": "src/legacy/core_plugins/status_page",
     "telemetry": ["src/plugins/telemetry", "src/plugins/telemetry_management_section"],

diff --git a/api_docs/security_oss.json b/api_docs/security_oss.json
diff --git a/api_docs/security_oss.mdx b/api_docs/security_oss.mdx
diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc
@@ -223,11 +223,6 @@ oss plugins.
 |The service exposed by this plugin informs consumers whether they should optimize for non-interactivity. In this way plugins can avoid loading unnecessary code, data or other services.
 
 
-|{kib-repo}blob/{branch}/src/plugins/security_oss/README.md[securityOss]
-|securityOss is responsible for educating users about Elastic's free security features,
-so they can properly protect the data within their clusters.
-
-
 |{kib-repo}blob/{branch}/src/plugins/share/README.md[share]
 |The share plugin contains various utilities for displaying sharing context menu,
 generating deep links to other apps, and creating short URLs.

diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml
@@ -64,7 +64,6 @@ pageLoadAssetSize:
   savedObjectsTaggingOss: 20590
   searchprofiler: 67080
   security: 95864
-  securityOss: 30806
   share: 99061
   snapshotRestore: 79032
   spaces: 57868

diff --git a/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker b/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker
@@ -371,6 +371,7 @@ kibana_vars=(
     xpack.security.session.idleTimeout
     xpack.security.session.lifespan
     xpack.security.sessionTimeout
+    xpack.security.showInsecureClusterWarning
     xpack.securitySolution.alertMergeStrategy
     xpack.securitySolution.alertIgnoreFields
     xpack.securitySolution.endpointResultListDefaultFirstPageIndex

diff --git a/src/plugins/security_oss/README.md b/src/plugins/security_oss/README.md
diff --git a/src/plugins/security_oss/common/app_state.ts b/src/plugins/security_oss/common/app_state.ts
diff --git a/src/plugins/security_oss/common/index.ts b/src/plugins/security_oss/common/index.ts
diff --git a/src/plugins/security_oss/jest.config.js b/src/plugins/security_oss/jest.config.js
diff --git a/src/plugins/security_oss/kibana.json b/src/plugins/security_oss/kibana.json
diff --git a/src/plugins/security_oss/public/app_state/app_state_service.mock.ts b/src/plugins/security_oss/public/app_state/app_state_service.mock.ts