Skip to content

Commit

Permalink
Use monacco editor in the inspector request panel (#82272)
Browse files Browse the repository at this point in the history
* Use monacco editor in the inspector request panel

Closes: #81921

* insRequestCodeViewer -> insRequestCodeViewer

* remove uiSettings from props

* fix functional tests

Co-authored-by: Kibana Machine <[email protected]>
  • Loading branch information
alexwizp and kibanamachine authored Nov 6, 2020
1 parent e378555 commit 0faf8c2
Show file tree
Hide file tree
Showing 17 changed files with 402 additions and 450 deletions.
11 changes: 9 additions & 2 deletions src/plugins/inspector/public/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class InspectorPublicPlugin implements Plugin<Setup, Start> {
public async setup(core: CoreSetup) {
this.views = new InspectorViewRegistry();

this.views.register(getDataViewDescription(core.uiSettings));
this.views.register(getDataViewDescription());
this.views.register(getRequestsViewDescription());

return {
Expand Down Expand Up @@ -101,7 +101,14 @@ export class InspectorPublicPlugin implements Plugin<Setup, Start> {
}

return core.overlays.openFlyout(
toMountPoint(<InspectorPanel views={views} adapters={adapters} title={options.title} />),
toMountPoint(
<InspectorPanel
views={views}
adapters={adapters}
title={options.title}
dependencies={{ uiSettings: core.uiSettings }}
/>
),
{
'data-test-subj': 'inspectorPanel',
closeButtonAriaLabel: closeButtonLabel,
Expand Down
Loading

0 comments on commit 0faf8c2

Please sign in to comment.