Review feedback

elastic · Feb 23, 2024 · 093e8bb · 093e8bb
1 parent a9f8b2f
commit 093e8bb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 80 deletions.
diff --git a/...ss/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments.cy.ts b/...ss/e2e/detection_response/detection_engine/detection_alerts/assignments/assignments.cy.ts
@@ -57,24 +57,19 @@ describe('Alert user assignment - ESS & Serverless', { tags: ['@ess', '@serverle
   });
 
   context('Basic rendering', () => {
-    it('alert with no assignees in alerts table', () => {
+    it('alert with no assignees in alerts table & details flyout', () => {
       checkEmptyAssigneesStateInAlertsTable();
-    });
 
-    it(`alert with no assignees in alert's details flyout`, () => {
       expandFirstAlert();
       checkEmptyAssigneesStateInAlertDetailsFlyout();
     });
 
-    it('alert with some assignees in alerts table', () => {
+    it('alert with some assignees in alerts table & details flyout', () => {
       const users = [getDefaultUserName()];
       updateAssigneesForFirstAlert(users);
+
       alertsTableShowsAssigneesForAlert(users);
-    });
 
-    it(`alert with some assignees in alert's details flyout`, () => {
-      const users = [getDefaultUserName()];
-      updateAssigneesForFirstAlert(users);
       expandFirstAlert();
       alertDetailsFlyoutShowsAssignees(users);
     });
@@ -124,56 +119,6 @@ describe('Alert user assignment - ESS & Serverless', { tags: ['@ess', '@serverle
       alertsTableShowsAssigneesForAlert(users);
     });
 
-    it('updating assignees via `More actions` in alerts table', () => {
-      // Initially assigned users
-      const initialAssignees = [getDefaultUserName()];
-      updateAssigneesForFirstAlert(initialAssignees);
-      alertsTableShowsAssigneesForAlert(initialAssignees);
-
-      // Update assignees
-      const updatedAssignees = [getDefaultUserName()];
-      updateAssigneesForFirstAlert(updatedAssignees);
-
-      // There should be no assigned alerts
-      checkEmptyAssigneesStateInAlertsTable();
-    });
-
-    it('updating assignees via add button in flyout', () => {
-      expandFirstAlert();
-
-      // Initially assigned users
-      const initialAssignees = [getDefaultUserName()];
-      updateAssigneesViaAddButtonInFlyout(initialAssignees);
-      alertDetailsFlyoutShowsAssignees(initialAssignees);
-
-      // Update assignees
-      const updatedAssignees = [getDefaultUserName()];
-      updateAssigneesViaAddButtonInFlyout(updatedAssignees);
-
-      // There should be no assigned alerts
-      checkEmptyAssigneesStateInAlertDetailsFlyout();
-      closeAlertFlyout();
-      checkEmptyAssigneesStateInAlertsTable();
-    });
-
-    it('updating assignees via `Take action` button in flyout', () => {
-      expandFirstAlert();
-
-      // Initially assigned users
-      const initialAssignees = [getDefaultUserName()];
-      updateAssigneesViaTakeActionButtonInFlyout(initialAssignees);
-      alertDetailsFlyoutShowsAssignees(initialAssignees);
-
-      // Update assignees
-      const updatedAssignees = [getDefaultUserName()];
-      updateAssigneesViaTakeActionButtonInFlyout(updatedAssignees);
-
-      // There should be no assigned alerts
-      checkEmptyAssigneesStateInAlertDetailsFlyout();
-      closeAlertFlyout();
-      checkEmptyAssigneesStateInAlertsTable();
-    });
-
     it('removing all assignees via `More actions` in alerts table', () => {
       // Initially assigned users
       const initialAssignees = [getDefaultUserName()];
@@ -217,23 +162,6 @@ describe('Alert user assignment - ESS & Serverless', { tags: ['@ess', '@serverle
       alertsTableShowsAssigneesForAllAlerts(users);
     });
 
-    it('updating assignees should be reflected in UI (alerts table)', () => {
-      selectFirstPageAlerts();
-
-      // Initially assigned users
-      const initialAssignees = [getDefaultUserName()];
-      bulkUpdateAssignees(initialAssignees);
-      alertsTableShowsAssigneesForAllAlerts(initialAssignees);
-
-      // Update assignees
-      selectFirstPageAlerts();
-      const updatedAssignees = [getDefaultUserName()];
-      bulkUpdateAssignees(updatedAssignees);
-
-      // There should be no assigned alerts
-      checkEmptyAssigneesStateInAlertsTable();
-    });
-
     it('removing all assignees should be reflected in UI (alerts table)', () => {
       selectFirstPageAlerts();
 

diff --git a/...n_response/detection_engine/detection_alerts/assignments/assignments_multiple_users.cy.ts b/...n_response/detection_engine/detection_alerts/assignments/assignments_multiple_users.cy.ts
@@ -70,15 +70,12 @@ describe(
     });
 
     context('Basic rendering', () => {
-      it('alert with some assignees in alerts table', () => {
+      it('alert with some assignees in alerts table & details flyout', () => {
         const users = [ROLES.detections_admin, ROLES.t1_analyst];
         updateAssigneesForFirstAlert(users);
+
         alertsTableShowsAssigneesForAlert(users);
-      });
 
-      it(`alert with some assignees in alert's details flyout`, () => {
-        const users = [ROLES.detections_admin, ROLES.t1_analyst];
-        updateAssigneesForFirstAlert(users);
         expandFirstAlert();
         alertDetailsFlyoutShowsAssignees(users);
       });