[Embeddable] remove Container class (#204105)

PR does the following * Removes Container class and IContainer interface * Removes parent from Embeddable class * Removes more dead code from embeddable plugin like EmbeddablePanel component * Cleans up all usages of Container and IContainer --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
elastic · Dec 16, 2024 · 08e7298 · 08e7298
1 parent c4b5a37
commit 08e7298
Show file tree

Hide file tree

Showing 43 changed files with 128 additions and 2,487 deletions.
diff --git a/src/plugins/dashboard/public/dashboard_app/top_nav/dashboard_editing_toolbar.tsx b/src/plugins/dashboard/public/dashboard_app/top_nav/dashboard_editing_toolbar.tsx
@@ -80,12 +80,6 @@ export function DashboardEditingToolbar({ isDisabled }: { isDisabled?: boolean }
     [dashboardApi]
   );
 
-  /**
-   * embeddableFactory: Required, you can get the factory from embeddableStart.getEmbeddableFactory(<embeddable type, i.e. lens>)
-   * initialInput: Optional, use it in case you want to pass your own input to the factory
-   * dismissNotification: Optional, if not passed a toast will appear in the dashboard
-   */
-
   const controlGroupApi = useStateFromPublishingSubject(dashboardApi.controlGroupApi$);
   const extraButtons = [
     <EditorMenu createNewVisType={createNewVisType} isDisabled={isDisabled} />,

diff --git a/src/plugins/dashboard/public/dashboard_container/types.ts b/src/plugins/dashboard/public/dashboard_container/types.ts
@@ -7,7 +7,6 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import type { ContainerOutput } from '@kbn/embeddable-plugin/public';
 import { SerializableRecord } from '@kbn/utility-types';
 
 import { ControlGroupRuntimeState } from '@kbn/controls-plugin/public';
@@ -34,10 +33,6 @@ export interface DashboardRenderPerformanceStats {
   panelsRenderStartTime: number;
 }
 
-export interface DashboardContainerOutput extends ContainerOutput {
-  usedDataViewIds?: string[];
-}
-
 export type DashboardLoadedEventStatus = 'done' | 'error';
 
 export interface DashboardLoadedEventMeta {

diff --git a/src/plugins/embeddable/public/embeddable_panel/embeddable_panel.tsx b/src/plugins/embeddable/public/embeddable_panel/embeddable_panel.tsx
diff --git a/src/plugins/embeddable/public/embeddable_panel/index.ts b/src/plugins/embeddable/public/embeddable_panel/index.ts
diff --git a/src/plugins/embeddable/public/embeddable_panel/types.ts b/src/plugins/embeddable/public/embeddable_panel/types.ts
diff --git a/src/plugins/embeddable/public/index.ts b/src/plugins/embeddable/public/index.ts
@@ -12,11 +12,9 @@ import { EmbeddablePublicPlugin } from './plugin';
 
 export { useAddFromLibraryTypes } from './add_from_library/registry';
 export { openAddFromLibraryFlyout } from './add_from_library/open_add_from_library_flyout';
-export { EmbeddablePanel } from './embeddable_panel';
 export {
   cellValueTrigger,
   CELL_VALUE_TRIGGER,
-  Container,
   contextMenuTrigger,
   CONTEXT_MENU_TRIGGER,
   defaultEmbeddableFactoryProvider,
@@ -58,9 +56,6 @@ export type {
   Adapters,
   CellValueContext,
   ChartActionContext,
-  ContainerInput,
-  ContainerOutput,
-  EmbeddableContainerSettings,
   EmbeddableContext,
   EmbeddableEditorState,
   EmbeddableFactory,
@@ -70,11 +65,9 @@ export type {
   EmbeddableOutput,
   EmbeddablePackageState,
   FilterableEmbeddable,
-  IContainer,
   IEmbeddable,
   MultiValueClickContext,
   OutputSpec,
-  PanelState,
   PropertySpec,
   RangeSelectContext,
   ReferenceOrValueEmbeddable,