change interface of renderApp in resolver_test plugin

elastic · Dec 5, 2019 · 075ed03 · 075ed03
1 parent f11281e
commit 075ed03
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/.../test/plugin_functional/plugins/resolver_test/public/applications/resolver_test/index.tsx b/.../test/plugin_functional/plugins/resolver_test/public/applications/resolver_test/index.tsx
@@ -6,7 +6,7 @@
 
 import * as React from 'react';
 import ReactDOM from 'react-dom';
-import { AppMountContext, AppMountParameters } from 'kibana/public';
+import { AppMountParameters } from 'kibana/public';
 import { I18nProvider } from '@kbn/i18n/react';
 import { IEmbeddable } from 'src/plugins/embeddable/public';
 import { useEffect } from 'react';
@@ -15,10 +15,9 @@ import { useEffect } from 'react';
  * This module will be loaded asynchronously to reduce the bundle size of your plugin's main bundle.
  */
 export function renderApp(
-  ...args: [AppMountContext, AppMountParameters, Promise<IEmbeddable | undefined>]
+  { element }: AppMountParameters,
+  embeddable: Promise<IEmbeddable | undefined>
 ) {
-  const [, { element }, embeddable] = args;
-
   ReactDOM.render(
     <I18nProvider>
       <AppRoot embeddable={embeddable} />

diff --git a/x-pack/test/plugin_functional/plugins/resolver_test/public/plugin.ts b/x-pack/test/plugin_functional/plugins/resolver_test/public/plugin.ts
@@ -23,9 +23,9 @@ export class ResolverTestPlugin implements Plugin {
       title: i18n.translate('xpack.resolver_test.pluginTitle', {
         defaultMessage: 'Resolver Test',
       }),
-      mount: async (context, params) => {
+      mount: async (_context, params) => {
         const { renderApp } = await import('./applications/resolver_test');
-        return renderApp(context, params, this.embeddablePromise);
+        return renderApp(params, this.embeddablePromise);
       },
     });
   }