Create connector modal won't change

elastic · Mar 6, 2020 · 06019dd · 06019dd
1 parent 81733f7
commit 06019dd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 14 deletions.
diff --git a/...rs_actions_ui/public/application/sections/action_connector_form/action_connector_form.tsx b/...rs_actions_ui/public/application/sections/action_connector_form/action_connector_form.tsx
@@ -42,6 +42,9 @@ interface ActionConnectorProps {
   connector: ActionConnector;
   dispatch: React.Dispatch<ReducerAction>;
   actionTypeName: string;
+  serverError?: {
+    body: { message: string; error: string };
+  };
   errors: IErrorObject;
   actionTypeRegistry: TypeRegistry<ActionTypeModel>;
 }
@@ -50,6 +53,7 @@ export const ActionConnectorForm = ({
   connector,
   dispatch,
   actionTypeName,
+  serverError,
   errors,
   actionTypeRegistry,
 }: ActionConnectorProps) => {
@@ -106,7 +110,7 @@ export const ActionConnectorForm = ({
   const FieldsComponent = actionTypeRegistered.actionConnectorFields;
 
   return (
-    <EuiForm>
+    <EuiForm isInvalid={!!serverError} error={serverError?.body.message}>
       <EuiFormRow
         id="actionName"
         fullWidth

diff --git a/...gers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx b/...gers_actions_ui/public/application/sections/action_connector_form/connector_add_modal.tsx
@@ -58,10 +58,14 @@ export const ConnectorAddModal = ({
   const setConnector = (value: any) => {
     dispatch({ command: { type: 'setConnector' }, payload: { key: 'connector', value } });
   };
+  const [serverError, setServerError] = useState<{
+    body: { message: string; error: string };
+  } | null>(null);
 
   const closeModal = useCallback(() => {
     setAddModalVisibility(false);
     setConnector(initialConnector);
+    setServerError(null);
   }, [initialConnector, setAddModalVisibility]);
 
   if (!addModalVisible) {
@@ -93,19 +97,7 @@ export const ConnectorAddModal = ({
         return savedConnector;
       })
       .catch(errorRes => {
-        if (toastNotifications) {
-          toastNotifications.addDanger(
-            i18n.translate(
-              'xpack.triggersActionsUI.sections.addModalConnectorForm.createErrorNotificationText',
-              {
-                defaultMessage: 'Failed to create connector: {message}',
-                values: {
-                  message: errorRes.body?.message ?? '',
-                },
-              }
-            )
-          );
-        }
+        setServerError(errorRes);
         return undefined;
       });
 
@@ -153,6 +145,7 @@ export const ConnectorAddModal = ({
             connector={connector}
             actionTypeName={actionType.name}
             dispatch={dispatch}
+            serverError={serverError}
             errors={errors}
             actionTypeRegistry={actionTypeRegistry}
           />