Fix type issues

x-pack/legacy/plugins/apm/cypress/cypress/support/index.js → x-pack/legacy/plugins/apm/cypress/cypress/support/index.ts

@@ -19,13 +19,9 @@
 // https://on.cypress.io/configuration
 // ***********************************************************
 
-// Import commands.js using ES2015 syntax:
 import './commands';
 
-// Alternatively you can use CommonJS syntax:
-// require('./commands')
-
 // @ts-ignore
 import { register } from '@cypress/snapshot';
 
-register();
+register();

x-pack/legacy/plugins/apm/cypress/cypress/support/step_definitions/apm.ts

@@ -1,15 +1,12 @@
-/// <reference types="Cypress" />
-
 /*
  * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
 
+import { Given, When, Then } from 'cypress-cucumber-preprocessor/steps';
 import { loginAndWaitForPage } from '../../integration/helpers';
 
-const { Given, When, Then } = require('cypress-cucumber-preprocessor/steps');
-
 Given(`a user browses the APM UI application`, () => {
   // open service overview page
   loginAndWaitForPage(`/app/apm#/services`);

x-pack/legacy/plugins/apm/cypress/cypress/support/index.d.ts → x-pack/legacy/plugins/apm/cypress/cypress/typings/index.d.ts

@@ -1,18 +1,9 @@
-/// <reference types="Cypress" />
-
 /*
  * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
 
-// typically custom commands are added in this support folder
-// so it makes sense to put their TypeScript definitions here
-// from the JavaScript specs loads this file using
-// the triple slash "reference" comment like this:
-//
-// /// <reference path="../support/index.d.ts" />
-
 declare namespace Cypress {
   interface Chainable<Subject> {
     snapshot: () => {};

x-pack/legacy/plugins/apm/cypress/package.json

@@ -10,6 +10,7 @@
   "dependencies": {
     "@cypress/snapshot": "^2.1.3",
     "@cypress/webpack-preprocessor": "^4.1.0",
+    "@types/cypress-cucumber-preprocessor": "^1.14.0",
     "@types/js-yaml": "^3.12.1",
     "@types/node": "^10.12.11",
     "cypress": "^3.5.0",

x-pack/legacy/plugins/apm/cypress/tsconfig.json

@@ -1,8 +1,13 @@
 {
   "extends": "../../../../tsconfig.json",
   "exclude": [],
-  "include": ["./**/*"],
+  "include": [
+    "./**/*"
+  ],
   "compilerOptions": {
-    "types": ["cypress", "node"]
+    "types": [
+      "cypress",
+      "node"
+    ]
   }
 }

x-pack/legacy/plugins/apm/cypress/yarn.lock

@@ -1197,11 +1197,21 @@
     debug "^3.1.0"
     lodash.once "^4.1.1"
 
+"@types/cypress-cucumber-preprocessor@^1.14.0":
+  version "1.14.0"
+  resolved "https://registry.yarnpkg.com/@types/cypress-cucumber-preprocessor/-/cypress-cucumber-preprocessor-1.14.0.tgz#41d8ffb2b608d3ed4ab998a0c4394056f75af1e0"
+  integrity sha512-bOl4u6seZtxNIGa6J6xydroPntTxxWy8uqIrZ3OY10C96fUes4mZvJKY6NvOoe61/OVafG/UEFa+X2ZWKE6Ltw==
+
 "@types/js-yaml@^3.12.1":
   version "3.12.1"
   resolved "https://registry.yarnpkg.com/@types/js-yaml/-/js-yaml-3.12.1.tgz#5c6f4a1eabca84792fbd916f0cb40847f123c656"
   integrity sha512-SGGAhXLHDx+PK4YLNcNGa6goPf9XRWQNAUUbffkwVGGXIxmDKWyGGL4inzq2sPmExu431Ekb9aEMn9BkPqEYFA==
 
+"@types/node@^10.12.11":
+  version "10.17.14"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.17.14.tgz#b6c60ebf2fb5e4229fdd751ff9ddfae0f5f31541"
+  integrity sha512-G0UmX5uKEmW+ZAhmZ6PLTQ5eu/VPaT+d/tdLd5IFsKRPcbe6lPxocBtcYBFSaLaCW8O60AX90e91Nsp8lVHCNw==
+
 "@types/[email protected]":
   version "2.3.2"
   resolved "https://registry.yarnpkg.com/@types/sizzle/-/sizzle-2.3.2.tgz#a811b8c18e2babab7d542b3365887ae2e4d9de47"
@@ -5761,10 +5771,10 @@ typedarray@^0.0.6:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-[email protected].2:
-  version "3.7.2"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.2.tgz#27e489b95fa5909445e9fef5ee48d81697ad18fb"
-  integrity sha512-ml7V7JfiN2Xwvcer+XAf2csGO1bPBdRbFCkYBczNZggrBZ9c7G3riSUeJmqEU5uOtXNPMhE3n+R4FA/3YOAWOQ==
+[email protected].5:
+  version "3.7.5"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.5.tgz#0692e21f65fd4108b9330238aac11dd2e177a1ae"
+  integrity sha512-/P5lkRXkWHNAbcJIiHPfRoKqyd7bsyCma1hZNUGfn20qm64T6ZBlrzprymeu918H+mB/0rIg2gGK/BXkhhYgBw==
 
 umd@^3.0.0:
   version "3.0.3"