👌 Integrate new feedback

elastic · Jan 14, 2021 · 012297a · 012297a
1 parent 49524fe
commit 012297a
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 10 deletions.
diff --git a/...ens/public/indexpattern_datasource/operations/definitions/calculations/moving_average.tsx b/...ens/public/indexpattern_datasource/operations/definitions/calculations/moving_average.tsx
@@ -178,7 +178,7 @@ const MovingAveragePopup = () => {
       button={
         <HelpPopoverButton onClick={() => setIsPopoverOpen(!isPopoverOpen)}>
           {i18n.translate('xpack.lens.indexPattern.movingAverage.helpText', {
-            defaultMessage: 'How does it work?',
+            defaultMessage: 'How moving average works',
           })}
         </HelpPopoverButton>
       }
@@ -198,15 +198,15 @@ const MovingAveragePopup = () => {
       <p>
         <FormattedMessage
           id="xpack.lens.indexPattern.movingAverage.longerExplanation"
-          defaultMessage="To calculate the moving average, **Lens** uses the mean of the window and applies a skip policy for gaps.
+          defaultMessage="To calculate the moving average, Lens uses the mean of the window and applies a skip policy for gaps.
             For missing values, the bucket is skipped and the calculation is performed on the next value."
         />
       </p>
 
       <p>
         <FormattedMessage
           id="xpack.lens.indexPattern.movingAverage.tableExplanation"
-          defaultMessage="For example, given the data [1, 2, 3, 4, 5, 6, 7, 8, 9, 10], we can calculate a simple moving average with windows size of 5 as follows:"
+          defaultMessage="For example, given the data [1, 2, 3, 4, 5, 6, 7, 8, 9, 10], we can calculate a simple moving average with a window size of 5 as follows:"
         />
       </p>
 
@@ -223,11 +223,23 @@ const MovingAveragePopup = () => {
           defaultMessage="The window does not include the current value."
         />
       </p>
+      <p>
+        <FormattedMessage
+          id="xpack.lens.indexPattern.movingAverage.windowInitialPartial"
+          defaultMessage="For the initial part of the series the window is partial, until it reaches the requested number of items. For instance with a window size of 5:"
+        />
+      </p>
+      <ul>
+        <li>(1 + 2) / 2 = 1.5</li>
+        <li>(1 + 2 + 3) / 3 = 2</li>
+        <li>(1 + 2 + 3 + 4) / 4 = 2.5</li>
+        <li>(1 + 2 + 3 + 4 + 5) / 5 = 3</li>
+      </ul>
 
       <p>
         <FormattedMessage
           id="xpack.lens.indexPattern.movingAverage.limitations"
-          defaultMessage=" The moving average is supported only for date histograms."
+          defaultMessage="Note the first moving average value start from the second item onward. The moving average is supported only for date histograms."
         />
       </p>
     </HelpPopover>

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/date_histogram.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/date_histogram.tsx
@@ -356,7 +356,7 @@ const AutoDateHistogramPopover = ({ data }: { data: DataPublicPluginStart }) =>
       button={
         <HelpPopoverButton onClick={() => setIsPopoverOpen(!isPopoverOpen)}>
           {i18n.translate('xpack.lens.indexPattern.dateHistogram.autoHelpText', {
-            defaultMessage: 'How does it work?',
+            defaultMessage: 'How date histogram works',
           })}
         </HelpPopoverButton>
       }
@@ -375,7 +375,7 @@ const AutoDateHistogramPopover = ({ data }: { data: DataPublicPluginStart }) =>
       <p>
         <FormattedMessage
           id="xpack.lens.indexPattern.dateHistogram.autoLongerExplanation"
-          defaultMessage="**Lens** automatically chooses an interval for you by dividing the specified time range by the 
+          defaultMessage="Lens automatically chooses an interval for you by dividing the specified time range by the 
                   {targetBarSetting} advanced setting. The calculation tries to present “nice” time interval buckets. The maximum 
                   number of bars is set by the {maxBarSetting} value."
           values={{

diff --git a/...lugins/lens/public/indexpattern_datasource/operations/definitions/ranges/range_editor.tsx b/...lugins/lens/public/indexpattern_datasource/operations/definitions/ranges/range_editor.tsx
@@ -34,14 +34,14 @@ const GranularityHelpPopover = () => {
       button={
         <HelpPopoverButton onClick={() => setIsPopoverOpen(!isPopoverOpen)}>
           {i18n.translate('xpack.lens.indexPattern.ranges.granularityHelpText', {
-            defaultMessage: 'How does it work?',
+            defaultMessage: 'How interval granularity works',
           })}
         </HelpPopoverButton>
       }
       closePopover={() => setIsPopoverOpen(false)}
       isOpen={isPopoverOpen}
       title={i18n.translate('xpack.lens.indexPattern.ranges.granularityPopoverTitle', {
-        defaultMessage: 'How does interval granularity work?',
+        defaultMessage: 'How granularity interval works',
       })}
     >
       <p>

diff --git a/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx b/x-pack/plugins/lens/public/xy_visualization/xy_config_panel.tsx
@@ -336,8 +336,7 @@ export function XyToolbar(props: VisualizationToolbarProps<State>) {
                       <EuiIconTip
                         color="subdued"
                         content={i18n.translate('xpack.lens.xyChart.missingValuesLabelHelpText', {
-                          defaultMessage: `When there are missing values in an area or line chart these can be represented in different ways in **Lens**. Missing values are drawn using dotted 
-    lines, and will not fill missing values at the left side of the chart.`,
+                          defaultMessage: `Gaps in the data are not shown by default, but can be represented as dotted lines with different modes.`,
                         })}
                         iconProps={{
                           className: 'eui-alignTop',