Skip to content

Commit

Permalink
[8.x] [ML] Data frame analytics: Updates Results Explorer flyout foot…
Browse files Browse the repository at this point in the history
…er buttons alignment (#204735) (#204966)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Data frame analytics: Updates Results Explorer flyout footer
buttons alignment
(#204735)](#204735)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T15:33:42Z","message":"[ML]
Data frame analytics: Updates Results Explorer flyout footer buttons
alignment (#204735)\n\nFix for:
[#204601](https://github.com/elastic/kibana/issues/204601)\n\nAfter:\n\nResults
explorer:\n\n<img width=\"1074\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fd35934a-7136-4d77-8ef6-9b490b9c2436\"\n/>\n\nAnalytics
map:\n\n<img width=\"1074\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9ecaf66b-1aa0-4d6a-b537-926a0421bed7\"\n/>","sha":"21008d2759e8d25b0b65b19936fabf8ffeaa1630","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","backport:version","v8.18.0"],"title":"[ML]
Data frame analytics: Updates Results Explorer flyout footer buttons
alignment","number":204735,"url":"https://github.com/elastic/kibana/pull/204735","mergeCommit":{"message":"[ML]
Data frame analytics: Updates Results Explorer flyout footer buttons
alignment (#204735)\n\nFix for:
[#204601](https://github.com/elastic/kibana/issues/204601)\n\nAfter:\n\nResults
explorer:\n\n<img width=\"1074\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fd35934a-7136-4d77-8ef6-9b490b9c2436\"\n/>\n\nAnalytics
map:\n\n<img width=\"1074\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9ecaf66b-1aa0-4d6a-b537-926a0421bed7\"\n/>","sha":"21008d2759e8d25b0b65b19936fabf8ffeaa1630"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204735","number":204735,"mergeCommit":{"message":"[ML]
Data frame analytics: Updates Results Explorer flyout footer buttons
alignment (#204735)\n\nFix for:
[#204601](https://github.com/elastic/kibana/issues/204601)\n\nAfter:\n\nResults
explorer:\n\n<img width=\"1074\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/fd35934a-7136-4d77-8ef6-9b490b9c2436\"\n/>\n\nAnalytics
map:\n\n<img width=\"1074\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/9ecaf66b-1aa0-4d6a-b537-926a0421bed7\"\n/>","sha":"21008d2759e8d25b0b65b19936fabf8ffeaa1630"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
  • Loading branch information
kibanamachine and rbrtj authored Dec 19, 2024
1 parent 4004ec7 commit 0096008
Showing 1 changed file with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,18 @@ export function AnalyticsIdSelector({
</EuiFlyoutHeader>
<EuiFlyoutBody data-test-subj={'mlJobSelectorFlyoutBody'}>{renderTabs()}</EuiFlyoutBody>
<EuiFlyoutFooter>
<EuiFlexGroup>
<EuiFlexGroup justifyContent="spaceBetween">
<EuiFlexItem grow={false}>
<EuiButtonEmpty
iconType="cross"
onClick={closeFlyout}
data-test-subj="mlFlyoutAnalyticsSelectorButtonClose"
>
{i18n.translate('xpack.ml.analyticsSelector.closeFlyoutButton', {
defaultMessage: 'Close',
})}
</EuiButtonEmpty>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButton
onClick={applySelection}
Expand All @@ -295,17 +306,6 @@ export function AnalyticsIdSelector({
/>
</EuiButton>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonEmpty
iconType="cross"
onClick={closeFlyout}
data-test-subj="mlFlyoutAnalyticsSelectorButtonClose"
>
{i18n.translate('xpack.ml.analyticsSelector.closeFlyoutButton', {
defaultMessage: 'Close',
})}
</EuiButtonEmpty>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlyoutFooter>
</EuiFlyout>
Expand Down

0 comments on commit 0096008

Please sign in to comment.