addressing pr comments

elastic · Oct 19, 2020 · 0022636 · 0022636
1 parent d4515ed
commit 0022636
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/x-pack/plugins/apm/server/lib/helpers/transaction_error_rate.ts b/x-pack/plugins/apm/server/lib/helpers/transaction_error_rate.ts
@@ -37,15 +37,12 @@ export function calculateTransactionErrorPercentage(
     {}
   >
 ) {
-  const successfulTransactions =
-    outcomeResponse.buckets.find(
-      (bucket) => bucket.key === EventOutcome.success
-    )?.count.value ?? 0;
+  const outcomes = Object.fromEntries(
+    outcomeResponse.buckets.map(({ key, count }) => [key, count.value])
+  );
 
-  const failedTransactions =
-    outcomeResponse.buckets.find(
-      (bucket) => bucket.key === EventOutcome.failure
-    )?.count.value ?? 0;
+  const failedTransactions = outcomes[EventOutcome.failure] ?? 0;
+  const successfulTransactions = outcomes[EventOutcome.success] ?? 0;
 
   return failedTransactions / (successfulTransactions + failedTransactions);
 }