websocket: new generic integration #9926
Conversation
1. This makes the Filebeat Websocket input available as an integration package.
muskan-agarwal26
changed the title
muskan-agarwal26
changed the title
ShourieG
added
the
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
ShourieG
added
New Integration
|
/test |
|
@muskan-agarwal26, any updates on this ? |
Yes, We are addressing the comments and will update the PR soon. |
1. Changed the title as suggested in Readme and manifest. 2. Added support for state, regexp, redact and auth support in the hbs file. 3. Added another scenario for system test.
There was a problem hiding this comment.
Please reverse the order of function declarations. The convention in Go code is caller before callee.
| } | ||
| } | ||
|
|
||
| conn, err := upgrader.Upgrade(w, r, nil) |
There was a problem hiding this comment.
| conn, err := upgrader.Upgrade(w, r, nil) | |
| upgrader := websocket.Upgrader{ | |
| CheckOrigin: func(r *http.Request) bool { return true }, | |
| } | |
| conn, err := upgrader.Upgrade(w, r, nil) |
packages/websocket/_dev/deploy/docker/websocket-mock-service/main.go
Outdated
Show resolved
Hide resolved
|
/test |
1. Remove default value of URL from manifest. 2. Reverse the order of function declarations. 3. Added copyright header. 4. Removed note from readme and update screenshot.
|
/test |
There was a problem hiding this comment.
@muskan-agarwal26 looks like one of the system test is failing as its unable to find any hits.
|
/test |
There was a problem hiding this comment.
After 8.15, we should also plan to add config option url_program as per elastic/beats#39997
|
Hi @muskan-agarwal26, could you resolve the system test issues and some unresolved suggestions so we can merge this ? |
|
/test |
|
/test |
…rvice & changed port to 80
|
/test |
1 similar comment
|
/test |
|
/test |
|
The issue with system tests seems two fold:
The fix needs to come from both ends but from the input side the earliest would be 8.15.1. The service deployer fix could potentially come earlier but that depends on the team priorities. Right now for websocket integrations, system tests might need to be disabled. NOTE: The delay for the mock service seems to be an issue on some linux docker systems only and hence went unnoticed until now as mac machines don't seem to suffer from this. |
|
/test |
|
💚 Build Succeeded
History
|
|
UPDATE: The solution was as simple as adding a health check to the mock-service container. Thanks a lot @chrisberkhout for noticing this and @jsoriano for verifying in realtime. cc: @kcreddy. Tests are now passing. :) |
|
Package websocket - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=websocket |
Proposed commit message
This makes the Filebeat Websocket input available as an integration package.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots