-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http_endpoint: test ack api #9843
Conversation
9796993
to
71f4cee
Compare
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
- STREAM_USERNAME=abc123 | ||
- STREAM_PASSWORD=abc123 | ||
command: log --start-signal=SIGHUP --webhook-username=abc123 --webhook-password=abc123 --webhook-timeout=2m --delay=10s /sample_logs/test-webhook.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The STREAM_USERNAME
and STREAM_PASSWORD
need to be STREAM_WEBHOOK_{USERNAME,PASSWORD}
(plus they are redundant given the CLI flags). This goes all in on env config:
- STREAM_USERNAME=abc123 | |
- STREAM_PASSWORD=abc123 | |
command: log --start-signal=SIGHUP --webhook-username=abc123 --webhook-password=abc123 --webhook-timeout=2m --delay=10s /sample_logs/test-webhook.log | |
- STREAM_WEBHOOK_USERNAME=abc123 | |
- STREAM_WEBHOOK_PASSWORD=abc123 | |
- STREAM_WEBHOOK_TIMEOUT=2m | |
- STREAM_START_SIGNAL=SIGHUP | |
- STREAM_DELAY=10s | |
command: log /sample_logs/test-webhook.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These reflect what is above. Should I fix those too? Done
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
cc @efd6 |
Package http_endpoint - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=http_endpoint |
Proposed commit message
See title.
Note
This is a partner to elastic/beats#39410. The URL query param is ignored by the current version of filebeat, so the test is expected to work with the current version. It has also tested on the change at elastic/beats#39410 with the following outcome.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots