Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_endpoint: test ack api #9843

Merged
merged 2 commits into from
May 17, 2024
Merged

http_endpoint: test ack api #9843

merged 2 commits into from
May 17, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 13, 2024

Proposed commit message

See title.

Note

This is a partner to elastic/beats#39410. The URL query param is ignored by the current version of filebeat, so the test is expected to work with the current version. It has also tested on the change at elastic/beats#39410 with the following outcome.

╭───────────────┬─────────────┬───────────┬────────────┬────────┬─────────────────╮
│ PACKAGE       │ DATA STREAM │ TEST TYPE │ TEST NAME  │ RESULT │    TIME ELAPSED │
├───────────────┼─────────────┼───────────┼────────────┼────────┼─────────────────┤
│ http_endpoint │             │ system    │ http-acked │ PASS   │ 1m11.438697878s │
│ http_endpoint │             │ system    │ http       │ PASS   │   41.720220895s │
╰───────────────┴─────────────┴───────────┴────────────┴────────┴─────────────────╯

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:http_endpoint Custom HTTP Endpoint Logs Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels May 13, 2024
@efd6 efd6 self-assigned this May 13, 2024
@efd6 efd6 force-pushed the b39410-http_endpoint branch from 9796993 to 71f4cee Compare May 13, 2024 05:05
@efd6 efd6 marked this pull request as ready for review May 13, 2024 05:21
@efd6 efd6 requested a review from a team as a code owner May 13, 2024 05:21
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Comment on lines 22 to 24
- STREAM_USERNAME=abc123
- STREAM_PASSWORD=abc123
command: log --start-signal=SIGHUP --webhook-username=abc123 --webhook-password=abc123 --webhook-timeout=2m --delay=10s /sample_logs/test-webhook.log
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The STREAM_USERNAME and STREAM_PASSWORD need to be STREAM_WEBHOOK_{USERNAME,PASSWORD} (plus they are redundant given the CLI flags). This goes all in on env config:

Suggested change
- STREAM_USERNAME=abc123
- STREAM_PASSWORD=abc123
command: log --start-signal=SIGHUP --webhook-username=abc123 --webhook-password=abc123 --webhook-timeout=2m --delay=10s /sample_logs/test-webhook.log
- STREAM_WEBHOOK_USERNAME=abc123
- STREAM_WEBHOOK_PASSWORD=abc123
- STREAM_WEBHOOK_TIMEOUT=2m
- STREAM_START_SIGNAL=SIGHUP
- STREAM_DELAY=10s
command: log /sample_logs/test-webhook.log

Copy link
Contributor Author

@efd6 efd6 May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These reflect what is above. Should I fix those too? Done

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit d39c579 into elastic:main May 17, 2024
5 checks passed
@elasticmachine
Copy link

Package http_endpoint - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=http_endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:http_endpoint Custom HTTP Endpoint Logs Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants