Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zscaler_zia] Include cintip field to web log template in docs #9773

Merged
merged 2 commits into from
May 8, 2024
Merged

[zscaler_zia] Include cintip field to web log template in docs #9773

merged 2 commits into from
May 8, 2024

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

After fixing the mapping of cintip to source.nat.ip in #9727. We should add this field to the web log template in the integration's documentation so users who follow that template can receive that field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chemamartinez chemamartinez added Integration:zscaler_zia Zscaler Internet Access bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels May 2, 2024
@chemamartinez chemamartinez self-assigned this May 2, 2024
@chemamartinez chemamartinez marked this pull request as ready for review May 2, 2024 12:50
@chemamartinez chemamartinez requested a review from a team as a code owner May 2, 2024 12:50
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

🚀 Benchmarks report

Package zscaler_zia 👍(3) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
tunnel 4672.9 3472.22 -1200.68 (-25.69%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @chemamartinez

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

kcreddy
kcreddy approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@chemamartinez chemamartinez merged commit a9783c8 into elastic:main May 8, 2024
5 checks passed
@elasticmachine
Copy link

Package zscaler_zia - 2.19.2 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia

@chemamartinez chemamartinez deleted the zscaler-cintip-docs branch February 6, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@chemamartinez chemamartinez

Labels
bugfix Pull request that fixes a bug issue Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chemamartinez @elasticmachine @kcreddy