Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Logs] Clarify event hub name field description #9258

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Mar 3, 2024

Proposed commit message

Recent feedback indicates confusion among a few users who mistakenly
used the Event Hub Namespace instead of the Event Hub Name in the
field.

To address this and enhance user understanding, this PR makes the
following adjustments to the field's description:

  • Clearly defines the purpose of the field: Specifies that users
    should enter the name of the Event Hub they wish to connect to.
  • Delineates what the field is not for: Explicitly states that
    this field is not intended for the Event Hub Namespace name.

This distinction is crucial to prevent the recurrence of the
confusion and to ensure that the field is used as intended.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

CleanShot 2024-03-03 at 09 21 56@2x

@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Mar 3, 2024
@zmoog zmoog self-assigned this Mar 3, 2024
@elasticmachine
Copy link

elasticmachine commented Mar 3, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@zmoog zmoog marked this pull request as ready for review March 3, 2024 08:28
@zmoog zmoog requested review from a team as code owners March 3, 2024 08:28
@zmoog zmoog requested a review from alaudazzi March 3, 2024 08:28
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@botelastic
Copy link

botelastic bot commented Apr 2, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Apr 2, 2024
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@botelastic botelastic bot removed the Stalled label Apr 2, 2024
multi: false
required: true
show_user: true
description: >-
Elastic recommends using one event hub for each integration. Visit [Create an event hub](https://docs.elastic.co/integrations/azure#create-an-event-hub) to learn more. Use event hub names up to 30 characters long to avoid compatibility issues.
The event hub name that contains the logs to ingest. Do NOT use the event hub namespace here. Elastic recommends using one event hub for each integration. Visit [Create an event hub](https://docs.elastic.co/integrations/azure#create-an-event-hub) to learn more. Use event hub names up to 30 characters long to avoid compatibility issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion on this line,
The event hub name that contains the logs to ingest.
Can we rename like,
The name of the event hub that contains the logs to ingest.

packages/azure/changelog.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor editing suggestion, otherwise LGTM.

packages/azure/manifest.yml Outdated Show resolved Hide resolved
zmoog and others added 3 commits April 17, 2024 10:02
Recent feedback indicates confusion among users who mistakenly input
the Event Hub Namespace instead of the Event Hub Name in the relevant
field.

To address this and enhance user understanding, this commit makes the
following adjustments to the field's description:

- Clearly defines the purpose of the field: Specifies that users
  should enter the name of the Event Hub they wish to connect to.
- Delineates what the field is not for: Explicitly states that
  this field is not intended for the Event Hub Namespace name.

This distinction is crucial to prevent the recurrence of the
confusion and to ensure that the field is used as intended.
Co-authored-by: Arianna Laudazzi <[email protected]>
@zmoog zmoog force-pushed the zmoog/improve-eventhub-name-var-description branch from 2452b7e to 9aee86d Compare April 17, 2024 08:06
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @zmoog

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@zmoog zmoog merged commit 0284a6e into main Apr 17, 2024
5 checks passed
@zmoog zmoog deleted the zmoog/improve-eventhub-name-var-description branch April 17, 2024 08:27
@elasticmachine
Copy link

Package azure - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=azure

@andrewkroh andrewkroh added Integration:azure Azure Logs Integration:azure_metrics Azure Resource Metrics labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:azure_metrics Azure Resource Metrics Integration:azure Azure Logs Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants