Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MongoDB] Update the Kibana version condition for the fix of disk space exhaustion. #9221

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

ritalwar
Copy link
Contributor

Proposed commit message

This PR updates the Kibana version condition for MongoDB integration to address the fix for MongoDB disk space exhaustion.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar added the bugfix Pull request that fixes a bug issue label Feb 22, 2024
@ritalwar ritalwar requested a review from a team as a code owner February 22, 2024 08:51
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ritalwar ritalwar requested a review from muthu-mps February 22, 2024 09:13
@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@ritalwar ritalwar merged commit d4746d8 into elastic:main Feb 22, 2024
5 checks passed
@elasticmachine
Copy link

Package mongodb - 1.13.2 containing this change is available at https://epr.elastic.co/search?package=mongodb

gizas pushed a commit that referenced this pull request Mar 13, 2024
…ce exhaustion. (#9221)

* Update the Kibana version condition for disk space exhaustion.
@lucabelluccini
Copy link
Contributor

Hello @ritalwar,
The bug #9220 / #8683 is solved via elastic/beats#37688, which means we need beats to be upgraded to 8.12.2.

I do not get why we've bumped the Kibana minimum versions.
Even if Kibana is updated, a user might still run an old Elastic Agent version and therefore an old Beats version - and would still be affected by the original bug.

We should not confuse the Kibana minimum version by the Elastic Agent version IMHO.

@ishleenk17
Copy link
Contributor

ishleenk17 commented Jul 23, 2024

@lucabelluccini : I completely get your point here, that Elastic Agent and Kibana version can be different.

Since there is no specific versioning for the Elastic agent as discussed earlier as well , it is expected that if customers want to utilize a feature added in a new Beats release, they should update the agent to match the stack version. Given the current constraints with Elastic agent versioning, this is the best method to ensure compatibility and feature availability.

Until the Elastic agent versioning issue is resolved, this approach remains the most effective way to communicate the need for updates to customers.

Please let me know if you have some other thoughts on this Luca.

@lucabelluccini
Copy link
Contributor

I agree.

As a mitigation until the package spec will have the EA version, my suggestion would be to "hint" users the Kibana version is also the "recommended" version of EA to use, maybe via enhancing the integration docs page.

Right now we do not even have a public documentation on the meaning of the "Minimum Kibana version", plus the release notes might be confusing:
image

@ishleenk17
Copy link
Contributor

my suggestion would be to "hint" users the Kibana version is also the "recommended" version of EA to use, maybe via enhancing the integration docs page.

Yes, I agree we can mention in the changelog about the requirement to have the same EA version and Kibana version for these type of changes

qcorporation pushed a commit that referenced this pull request Feb 3, 2025
…ce exhaustion. (#9221)

* Update the Kibana version condition for disk space exhaustion.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
…ce exhaustion. (#9221)

* Update the Kibana version condition for disk space exhaustion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:mongodb MongoDB
Projects
None yet
6 participants