Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multivariant system test support for TSDB enabled package #8827

Closed
wants to merge 2 commits into from

Conversation

agithomas
Copy link
Contributor

  • Enhancement

Proposed commit message

Multivariant system test of TSDB enabled package requires 8.8.1 and above.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

#8741

Screenshots

image

@elasticmachine
Copy link

elasticmachine commented Jan 4, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@agithomas agithomas marked this pull request as ready for review January 17, 2024 06:38
@agithomas agithomas requested a review from a team as a code owner January 17, 2024 06:38
@agithomas agithomas requested a review from ritalwar January 17, 2024 07:39
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -153,6 +153,15 @@ A field that holds millions of unique values may not be an ideal candidate for b

# <a id="troubleshooting"></a> Troubleshooting

### Enabling multiple variants support in system tests

If the system test configuration for a TSDB-enabled package contains multiple variants, make sure to set the `kibana.version` specified in the `manifest.yml` file of the package to `8.8.1` or a version higher.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually an issue with any attempt to run the same system tests multiple times in the same deployment. I wonder if we should investigate some way to address this case in elastic-package.

I think the issue was fixed in elastic/elasticsearch#96461.

@elasticmachine
Copy link

elasticmachine commented Jan 18, 2024

💔 Build Failed

Failed CI Steps

History

@botelastic
Copy link

botelastic bot commented Feb 17, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Feb 17, 2024
@botelastic
Copy link

botelastic bot commented Mar 18, 2024

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants