-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multivariant system test support for TSDB enabled package #8827
Conversation
🚀 Benchmarks reportTo see the full report comment with |
Co-authored-by: Richa Talwar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -153,6 +153,15 @@ A field that holds millions of unique values may not be an ideal candidate for b | |||
|
|||
# <a id="troubleshooting"></a> Troubleshooting | |||
|
|||
### Enabling multiple variants support in system tests | |||
|
|||
If the system test configuration for a TSDB-enabled package contains multiple variants, make sure to set the `kibana.version` specified in the `manifest.yml` file of the package to `8.8.1` or a version higher. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually an issue with any attempt to run the same system tests multiple times in the same deployment. I wonder if we should investigate some way to address this case in elastic-package
.
I think the issue was fixed in elastic/elasticsearch#96461.
💔 Build Failed
Failed CI StepsHistory
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution! |
Proposed commit message
Multivariant system test of TSDB enabled package requires 8.8.1 and above.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
#8741
Screenshots