Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added output_health data stream to fleet_server #8605

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Nov 29, 2023

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Start kibana locally and upload the new version of the package from /build/packages folder (or use elastic-package)

curl -XPOST -H 'content-type: application/zip' -H 'kbn-xsrf: true' http://localhost:5601/api/fleet/epm/packages -u elastic:changeme --data-binary @fleet_server-1.5.0.zip

The package installs successfully and the index template is created with the right fields and ilm policy.
image
image

The data streams are going to be populated by fleet-server: elastic/fleet-server#3127
image

The output health will be queried by kibana by output id (output keyword field) to show the state of remote es outputs on UI

Related issues

Relates elastic/fleet-server#3116

Screenshots

@juliaElastic juliaElastic added the enhancement New feature or request label Nov 29, 2023
@juliaElastic juliaElastic self-assigned this Nov 29, 2023
@juliaElastic juliaElastic marked this pull request as ready for review November 29, 2023 12:27
@juliaElastic juliaElastic requested a review from a team as a code owner November 29, 2023 12:27
@elasticmachine
Copy link

elasticmachine commented Nov 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-29T12:27:30.806+0000

  • Duration: 15 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 33.333% (3/9) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these fields are not really serving any purpose (except @timestamp), added them out of convention

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliaElastic juliaElastic merged commit 1531461 into elastic:main Nov 30, 2023
4 checks passed
@elasticmachine
Copy link

Package fleet_server - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=fleet_server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:fleet_server Fleet Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants