Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integrations][Custom GCS] - Made integration GA, added new parameters & improved docs #8515

Merged
merged 4 commits into from
Nov 20, 2023
Merged

[integrations][Custom GCS] - Made integration GA, added new parameters & improved docs #8515

merged 4 commits into from
Nov 20, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Nov 15, 2023 •
edited
Loading

Type of change

  • Enhancement
  • Documentation

Proposed commit message

  • Refactored the integration.
  • Added support for new GCS Input parameters according to 8.11 features.
  • Updated Kibana requirements to be 8.11 and above.
  • Improved the documentation to be GA ready.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Note

This integration was tested manually with a real GCS bucket on cloud with 100k+ logs. Screenshot of testing is attached below.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Add here screenshots presenting:

  • Test results of running GCS integration with a real GCS bucket containing 100k+ logs
Screenshot 2023-11-15 at 2 10 43 PM

@ShourieG ShourieG requested a review from a team as a code owner November 15, 2023 11:00
@ShourieG ShourieG self-assigned this Nov 15, 2023
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@ShourieG ShourieG added enhancement New feature or request 8.11 candidate labels Nov 15, 2023
@ShourieG
Copy link
Contributor Author

/test

@ShourieG ShourieG assigned ShourieG and unassigned ShourieG Nov 15, 2023
@ShourieG ShourieG changed the title [integrations][GCS] - Made integration GA, added new parameters & improved docs [integrations][Custom GCS] - Made integration GA, added new parameters & improved docs Nov 15, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-20T11:13:51.148+0000

  • Duration: 17 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 100.0% (3/3) 💚 50.0
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

bhapas
bhapas approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

@ShourieG ShourieG merged commit c4de065 into elastic:main Nov 20, 2023
@ShourieG ShourieG deleted the gcs/ga branch November 20, 2023 14:52
@elasticmachine
Copy link

Package google_cloud_storage - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=google_cloud_storage

@taylor-swanson taylor-swanson mentioned this pull request Jan 5, 2024
Closed
18 tasks
@andrewkroh andrewkroh added the Integration:google_cloud_storage Custom GCS (Google Cloud Storage) Input label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@ShourieG ShourieG

Labels
8.11 candidate enhancement New feature or request Integration:google_cloud_storage Custom GCS (Google Cloud Storage) Input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update GCS integration to incorporate latest [GCS] input updates
4 participants
@ShourieG @elasticmachine @bhapas @andrewkroh