-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: make pipeline routing robust to channel letter case #8242
Conversation
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
Apparently some events from Windows servers and workstations in Security channel have a lowercase channel name. This has not been observed in other channels, but defensively apply the same care there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
But this has me thinking that we should be routing based exclusively on the provider name instead of the channel. The channel names may be customized in the case of forwarded events. Sometimes users will setup their WEC with custom channels so you might have something named "WEC-Security" that holds the data produced by Microsoft-Windows-Security-Auditing
. WDYT?
That seem reasonable. Here or later? |
Later. That will give me time to write up an issue tomorrow and think through some use cases relating to WEC. The goal is to make sure that WEC users can get the same behavior as if they had directly collected the logs from a host using Agent. So checking that we consistently apply |
Package windows - 1.40.0 containing this change is available at https://epr.elastic.co/search?package=windows |
Proposed commit message
Apparently some events from Windows servers and workstations in Security channel have a lowercase channel name. This has not been observed in other channels, but defensively apply the same care there.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots