-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust aws package to use input groups #767
Adjust aws package to use input groups #767
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
In its current state the |
Update: waiting on elastic/elastic-package#282 before working on this PR again |
@sorantis Yes! I think package wide |
yes, my bad, I looked at the diff only, which hid the existing |
Pinging @elastic/integrations (Team:Integrations) |
@kaiyan-sheng I assume we can't merge this package yet, as other parties don't support it yet? I mean Kibana and Package Registry. I'm not sure what would be implications of merging it now :) |
@mtojek Yeah I just tested the AWS integration with this PR and I definitely need to work on package registry first before this PR can get merged. |
Maybe mark this PR as draft to prevent from accidental merge :) |
@mtojek Done, back in draft mode! Thanks! |
The Meta elastic/package-spec#144 indicates that package registry changes have dependency on AWS package. Is it the other way around? Also, what should be done to unblock changes in Kibana? |
@sorantis I'm currently working on changes in package-registry elastic/package-registry#685 to unblock Kibana work. I also pointed this draft PR to @jen-huang and hopefully combining both draft PRs together will help. |
Hi all, I'm starting to assess Kibana work using the in-flight changes to AWS package in this PR along with the package registry changes. I have a question regarding the new package-level integrations/packages/aws/manifest.yml Lines 26 to 27 in e00cbd7
I know we introduced support for package-level @sorantis What do you think? If Kibana should support package-level vars as part of phase 1, can you provide some guidance on how they fit into the existing policy editor UI? |
@jen-huang My understanding is, for package-level vars, I would expect to see them under current |
Thanks @kaiyan-sheng, I think that makes sense. I've added supporting package-level vars to the Kibana scope for phase 1: elastic/kibana#93315 |
@jen-huang Done, please let me know if it works for you! Thank you!! |
@kaiyan-sheng Do input groups need a newer stack (7.14.0-SNAPSHOT)? If so, we need to bump it out in elastic-package. It's not a problem at all, but just asking in advance ;) |
Thanks for pointing this out @mtojek ! Yes we do need to limit the stack version. I'm thinking to change the |
FYI elastic/kibana#99866 is just the first part of the Kibana work, there is a second part to come :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, however conflicts should be resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR do?
This PR is to modify current
aws
package to use input groups in order to add icons for each service to support granular search.Checklist
changelog.yml
file.Related issues
Screenshots