-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent] Add queue depth, output batch size and rate #7611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
changed the title
[Elastic Agent] Add output queue depth and write batches
[Elastic Agent] Add input+output queue depth and write batches
Aug 30, 2023
🌐 Coverage report
|
faec
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except some description typos
packages/elastic_agent/data_stream/auditbeat_logs/fields/fields.yml
Outdated
Show resolved
Hide resolved
packages/elastic_agent/data_stream/auditbeat_logs/fields/fields.yml
Outdated
Show resolved
Hide resolved
cmacknz
reviewed
Aug 30, 2023
packages/elastic_agent/kibana/dashboard/elastic_agent-f47f18cc-9c7d-4278-b2ea-a6dee816d395.json
Show resolved
Hide resolved
cmacknz
reviewed
Aug 30, 2023
packages/elastic_agent/data_stream/auditbeat_logs/fields/fields.yml
Outdated
Show resolved
Hide resolved
Thanks @faec for catching my bad copy and paste 🤦 |
joshdover
changed the title
[Elastic Agent] Add input+output queue depth and write batches
[Elastic Agent] Add queue depth, output batch size and rate
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds more in depth metrics for viewing output batches sizes, batches/sec, and input queue sizes. This helps with tuning
workers
andbulk_max_size
to avoid filling up the queues.For the input queue metrics, we currently only have this data on the
logs-elastic_agent.*beat-*
data streams, rather than on themetrics-*
data streams. Fixing this requires some fixes in Agent and I'd like to get value out on this sooner, so I'm deciding to map these fields for now onlogs
and we'll fix later (opened elastic/elastic-agent#3334) on a future Agent version.@elastic/elastic-agent-data-plane I would like confirmation that I am interpreting this metric fields correctly.
Checklist
changelog.yml
file.How to test this PR locally
elastic-package stack up && elastic-package build && elastic-package install
Go to Fleet -> click on an Agent -> View more agent metrics
Related issues
Screenshots
Output write batches/sec
Output batch size by beat type
Queue depth by input