Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Fix agent dashboard links for non default spaces #7471

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Aug 21, 2023

What does this PR do?

Referencing dashboards with markdown needs to be space-aware. Currently it was using a hyperlink that would always choose the default space on many occasions, the PR simply changes the markdown links to the correct format.

Tested all the links on all the dashboards after the changes, and they are working fine.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Elastic Agent integration is installed by default, open up the Dashboards UI and click on the Agent Overview dashboard, then click on any of the links in the table of contents on the left, this should now work in any space for all the links.

Related issues

@P1llus P1llus added Team:Security-External Integrations Team:Elastic-Agent Label for the Agent team Integration:elastic_agent Elastic Agent bugfix Pull request that fixes a bug issue labels Aug 21, 2023
@P1llus P1llus requested a review from a team as a code owner August 21, 2023 09:58
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link

elasticmachine commented Aug 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-21T10:01:13.635+0000

  • Duration: 14 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 16.667
Classes 100.0% (0/0) 💚 16.667
Methods 33.333% (25/75) 👎 -55.952
Lines 100.0% (0/0) 💚 13.333
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Package elastic_agent - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=elastic_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:elastic_agent Elastic Agent Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in the dashboards from elastic agent integration are not working in a multi space environment
3 participants