Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Add ECS error.code mapping #6869

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[windows] Add ECS error.code mapping #6869

merged 1 commit into from
Jul 7, 2023

Conversation

andrewkroh
Copy link
Member

What does this PR do?

The winlog input can produce error.code under some conditions so make sure their is a mapping present for the field that is aligned to ECS.

Relates #6766

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@andrewkroh
windows - Add ECS error.code mapping
2169d44 
The winlog input can produce error.code under some conditions so
make sure their is a mapping present for the field that is aligned to ECS.

Relates elastic#6766
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:windows Windows labels Jul 7, 2023
@andrewkroh andrewkroh mentioned this pull request Jul 7, 2023
Closed
@andrewkroh andrewkroh marked this pull request as ready for review July 7, 2023 12:44
@andrewkroh andrewkroh requested review from a team as code owners July 7, 2023 12:44
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-07T12:41:27.909+0000

  • Duration: 16 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -12.5
Classes 87.5% (7/8) 👎 -12.5
Methods 83.696% (77/92) 👍 20.809
Lines 92.813% (5153/5552) 👎 -6.632
Conditionals 100.0% (0/0) 💚

@andrewkroh andrewkroh merged commit b310313 into elastic:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

@belimawr belimawr belimawr approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:windows Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewkroh @elasticmachine @belimawr @taylor-swanson