Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][AWS] Fix Incorrect fields in AWS Metrics Overview dashboard #6353

Merged
merged 3 commits into from
May 31, 2023
Merged

[O11y][AWS] Fix Incorrect fields in AWS Metrics Overview dashboard #6353

merged 3 commits into from
May 31, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented May 29, 2023 •
edited
Loading

  • Bug

What does this PR do?

Update AWS Metric visualizations with correct field names.

Old Field New Field
aws.ec2.cpu.total.pct host.cpu.usage
aws.elb.metrics.Latency aws.elb.metrics.Latency.avg
aws.elb.metrics.UnHealthyHostCount aws.elb.metrics.UnHealthyHostCount.max
aws.lambda.metrics.Invocations aws.lambda.metrics.Invocations.avg
aws.ecs.metrics.CPUUtilization aws.ecs.metrics.CPUUtilization.avg
aws.ecs.metrics.CPUReservation aws.ecs.metrics.CPUReservation.avg

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

@rajvi-patel-22 rajvi-patel-22 requested review from a team as code owners May 29, 2023 03:14
@elasticmachine
Copy link

elasticmachine commented May 29, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-29T03:14:57.804+0000

  • Duration: 57 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -4.992
Classes 93.75% (15/16) 👎 -4.992
Methods 86.131% (236/274) 👎 -8.266
Lines 85.925% (7387/8597) 👎 -7.684
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 self-assigned this May 29, 2023
harnish-elastic
harnish-elastic approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

milan-elastic
milan-elastic approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 3bd45cd into elastic:main May 31, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request May 31, 2023
Closed
@elasticmachine
Copy link

Package aws - 1.37.3 containing this change is available at https://epr.elastic.co/search?package=aws

agithomas pushed a commit to agithomas/integrations that referenced this pull request Jun 5, 2023
@rajvi-patel-22 @agithomas
[O11y][AWS] Fix Incorrect fields in AWS Metrics Overview dashboard (e…
10ad393 
…lastic#6353)

* Fix incorrect fields on multiple visualizations

* Update changelog

* Remove comment from changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@harnish-elastic harnish-elastic harnish-elastic approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
Integration:aws AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rajvi-patel-22 @elasticmachine @drewdaemon @kaiyan-sheng @harnish-elastic @milan-elastic @andrewkroh