-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Add API Gateway metrics data stream #6188
[AWS] Add API Gateway metrics data stream #6188
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
packages/aws/data_stream/apigateway_metrics/fields/package-fields.yml
Outdated
Show resolved
Hide resolved
@shmsr I was also confused by this for the longest time, not sure why AWS chose this naming scheme. Under https://docs.aws.amazon.com/apigateway/latest/developerguide/welcome.html, there are three "Working with..." for the supported APIs (HTTP, REST, WebSockets), each with variations in metrics/dimensions under Monitor/Metrics tab (ex: There are also some mentions of Snippet of event I got in
|
Oh, okay. Thanks for sharing! |
Co-authored-by: subham sarkar <[email protected]>
ecbca8a
to
51571d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
But as I'm still not much experienced with integrations as of now, I'd like to request you get another pair of eyes to review this PR. I might have missed something.
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
Co-authored-by: subham sarkar <[email protected]>
LGTM, I'll take a look at the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please considers adding the latency doc from the other PR.
LGTM.
Co-authored-by: Maurizio Branca <[email protected]>
Package aws - 1.39.0 containing this change is available at https://epr.elastic.co/search?package=aws |
* Add sample event * Add changelog entry * Add stream * Add manifest * Add fields * Add manifest entry * Fix fields * Add icon * Update descriptions * Update package-fields description Co-authored-by: subham sarkar <[email protected]> * Add unit and metric types * Add docs * Update packages/aws/_dev/build/docs/apigateway.md Co-authored-by: subham sarkar <[email protected]> * Update packages/aws/docs/apigateway.md Co-authored-by: subham sarkar <[email protected]> * Update packages/aws/manifest.yml Co-authored-by: subham sarkar <[email protected]> * Update packages/aws/docs/apigateway.md Co-authored-by: subham sarkar <[email protected]> * Update packages/aws/manifest.yml Co-authored-by: subham sarkar <[email protected]> * Update packages/aws/_dev/build/docs/apigateway.md Co-authored-by: subham sarkar <[email protected]> * Update packages/aws/data_stream/apigateway_metrics/manifest.yml Co-authored-by: Maurizio Branca <[email protected]> * fix apigateway docs --------- Co-authored-by: subham sarkar <[email protected]> Co-authored-by: Maurizio Branca <[email protected]>
What does this PR do?
Adds API Gateway metrics datastream which covers HTTP, REST and Websocket APIs.
Checklist
changelog.yml
file.Author checklist
Related issues
Concerns #6058
Closes #6270