Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for iptables syslog input #587

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Add system test for iptables syslog input #587

merged 1 commit into from
Feb 1, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jan 30, 2021

What does this PR do?

Add system test for the syslog input (udp) in the iptables log data stream.
Pipeline tests and a system test for the logfile input already existed.

Fixes

  • Handle missing iptables.raw_date when beats syslog input is used.
  • Add missing fields used by the beats syslog input.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

Related issues

Screenshots

--- Test results for package: iptables - START ---
╭──────────┬─────────────┬───────────┬───────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE  │ DATA STREAM │ TEST TYPE │ TEST NAME                                                             │ RESULT │ TIME ELAPSED │
├──────────┼─────────────┼───────────┼───────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ iptables │             │ asset     │ dashboard iptables-ceefb9e0-1f51-11e9-93ed-f7e068f4aebb is loaded     │ PASS   │  9.01833307s │
│ iptables │             │ asset     │ dashboard iptables-d39f0980-1ff3-11e9-ae2a-939083c6a64e is loaded     │ PASS   │      2.505µs │
│ iptables │             │ asset     │ visualization iptables-190bcb50-1ff6-11e9-ae2a-939083c6a64e is loaded │ PASS   │        460ns │
│ iptables │             │ asset     │ visualization iptables-1ba82fd0-1ff0-11e9-ae2a-939083c6a64e is loaded │ PASS   │        343ns │
│ iptables │             │ asset     │ visualization iptables-2599f5e0-1e98-11e9-8ec4-cf5d91a864b3 is loaded │ PASS   │        323ns │
│ iptables │             │ asset     │ visualization iptables-35fe0910-1f26-11e9-8ec4-cf5d91a864b3 is loaded │ PASS   │        316ns │
│ iptables │             │ asset     │ visualization iptables-4c913eb0-1f51-11e9-93ed-f7e068f4aebb is loaded │ PASS   │        304ns │
│ iptables │             │ asset     │ visualization iptables-5bd53050-1fe9-11e9-ae2a-939083c6a64e is loaded │ PASS   │        298ns │
│ iptables │             │ asset     │ visualization iptables-683402b0-1f29-11e9-8ec4-cf5d91a864b3 is loaded │ PASS   │        306ns │
│ iptables │             │ asset     │ visualization iptables-758b3620-1fda-11e9-ae2a-939083c6a64e is loaded │ PASS   │        324ns │
│ iptables │             │ asset     │ visualization iptables-8853aa20-1fef-11e9-ae2a-939083c6a64e is loaded │ PASS   │        307ns │
│ iptables │             │ asset     │ visualization iptables-b57b7370-1f1d-11e9-8ec4-cf5d91a864b3 is loaded │ PASS   │        305ns │
│ iptables │             │ asset     │ visualization iptables-c4394ec0-1efd-11e9-8ec4-cf5d91a864b3 is loaded │ PASS   │        329ns │
│ iptables │             │ asset     │ visualization iptables-d8cea010-1efd-11e9-8ec4-cf5d91a864b3 is loaded │ PASS   │        457ns │
│ iptables │             │ asset     │ visualization iptables-fdea1ad0-1ff4-11e9-ae2a-939083c6a64e is loaded │ PASS   │        464ns │
│ iptables │             │ asset     │ search iptables-7862cab0-1fdb-11e9-ae2a-939083c6a64e is loaded        │ PASS   │        767ns │
│ iptables │             │ asset     │ search iptables-9f7d97c0-1fe9-11e9-ae2a-939083c6a64e is loaded        │ PASS   │        413ns │
│ iptables │             │ asset     │ search iptables-b3f1b010-1f26-11e9-8ec4-cf5d91a864b3 is loaded        │ PASS   │        530ns │
│ iptables │             │ asset     │ search iptables-c4e80aa0-1fd4-11e9-ae2a-939083c6a64e is loaded        │ PASS   │        477ns │
│ iptables │ log         │ asset     │ index_template logs-iptables.log is loaded                            │ PASS   │        548ns │
│ iptables │ log         │ asset     │ ingest_pipeline logs-iptables.log-0.0.2 is loaded                     │ PASS   │        433ns │
╰──────────┴─────────────┴───────────┴───────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: iptables - END   ---
Done
Run pipeline tests for the package
--- Test results for package: iptables - START ---
╭──────────┬─────────────┬───────────┬───────────────────────┬────────┬──────────────╮
│ PACKAGE  │ DATA STREAM │ TEST TYPE │ TEST NAME             │ RESULT │ TIME ELAPSED │
├──────────┼─────────────┼───────────┼───────────────────────┼────────┼──────────────┤
│ iptables │ log         │ pipeline  │ test-iptables-raw.log │ PASS   │  45.999719ms │
╰──────────┴─────────────┴───────────┴───────────────────────┴────────┴──────────────╯
--- Test results for package: iptables - END   ---
Done
Run system tests for the package
--- Test results for package: iptables - START ---
╭──────────┬─────────────┬───────────┬───────────┬────────┬───────────────╮
│ PACKAGE  │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │  TIME ELAPSED │
├──────────┼─────────────┼───────────┼───────────┼────────┼───────────────┤
│ iptables │ log         │ system    │ logfile   │ PASS   │ 20.497683005s │
│ iptables │ log         │ system    │ syslog    │ PASS   │ 26.448020883s │
╰──────────┴─────────────┴───────────┴───────────┴────────┴───────────────╯
--- Test results for package: iptables - END   ---

Add system test for the syslog input (udp) in the iptables log data stream.
Pipeline tests and a system test for the logfile input already existed.

Fixes

- Handle missing iptables.raw_date when beats syslog input is used.
- Add missing fields used by the beats syslog input.
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #587 opened

    • Start Time: 2021-01-30T14:21:51.284+0000
  • Duration: 18 min 21 sec

  • Commit: 16c19f8

Test stats 🧪

Test Results
Failed 0
Passed 65
Skipped 0
Total 65

@andrewkroh andrewkroh merged commit dee8890 into elastic:master Feb 1, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Add system test for the syslog input (udp) in the iptables log data stream.
Pipeline tests and a system test for the logfile input already existed.

Fixes

- Handle missing iptables.raw_date when beats syslog input is used.
- Add missing fields used by the beats syslog input.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants