-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Add number_of_workers
and latency
to all CloudWatch Logs based integrations
#5794
Merged
zmoog
merged 4 commits into
main
from
zmoog/add-number-of-workers-option-to-cloudwatch-input
Apr 12, 2023
Merged
[AWS] Add number_of_workers
and latency
to all CloudWatch Logs based integrations
#5794
zmoog
merged 4 commits into
main
from
zmoog/add-number-of-workers-option-to-cloudwatch-input
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoog
added
enhancement
New feature or request
Team:Cloud-Monitoring
Label for the Cloud Monitoring team
labels
Apr 5, 2023
zmoog
changed the title
[AWS] Add number_of_workers and latency to all CloudWatch Logs based integrations
[AWS] Add Apr 5, 2023
number_of_workers
and latency
to all CloudWatch Logs based integrations
🌐 Coverage report
|
endorama
approved these changes
Apr 5, 2023
zmoog
force-pushed
the
zmoog/add-number-of-workers-option-to-cloudwatch-input
branch
from
April 6, 2023 14:35
5881d11
to
a7046f6
Compare
All the CloudWatch Logs based integration should have these options available to them. The `number_of_workers` is essential to increase the workers when users decide to use `log_group_name_prefix`. The `latency` can be required on the busiest log groups to deal with potential latency.
zmoog
force-pushed
the
zmoog/add-number-of-workers-option-to-cloudwatch-input
branch
from
April 7, 2023 17:00
a7046f6
to
e7de53c
Compare
zmoog
deleted the
zmoog/add-number-of-workers-option-to-cloudwatch-input
branch
April 12, 2023 17:40
Package aws - 1.33.3 containing this change is available at https://epr.elastic.co/search?package=aws |
4 tasks
TheLastHarpCo
suggested changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what I am doing or who Harpo is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Integration:aws_logs
Custom AWS Logs
Integration:aws
AWS
Team:Cloud-Monitoring
Label for the Cloud Monitoring team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Number of workers
When users set up the integration to collect logs from a single log group, the default value (
1
) fornumber_of_workers
is adequate to fetch the log events at each iteration.However, when users utilize
log_group_name_prefix
to collect log events from multiple log groups, according to elastic/beats#29695, thenumber_of_workers
should be increased to reach the number of log groups matching the prefix.Latency
The
latency
can be required on the busiest log groups to deal with potential latency.Conclusion
All the CloudWatch Logs-based integration should have these options available to them.
Change description
Updates the configuration template and integration variables to make these Filebeat configuration options available to the integration settings UI.
It also added a new "Advanced options" section under the "Setup" section to give more details about these options. I plan to add leverage this and other new sections to explain how the integration works.
Checklist
changelog.yml
file.How to test this PR locally
I created four logs groups with plain text data:
test-mbranca-groucho
test-mbranca-gummo
test-mbranca-harpo
test-mbranca-zeppo
And I configured a CloudWatch Logs integration with the following settings:
test-mbranca
<REGION FOR THE LOG GROUPS>
The only existing worker will pick up one log group at a time during each iteration.
Each log group will process data every four iterations.
Then I changed the following settings:
4
(previously was unset)The four available workers will pick up one log group each during each iteration.
Related issues