Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[panw] Enable RFC 6587 framing by default on TCP input #5787

Merged
merged 5 commits into from
Apr 5, 2023
Merged

[panw] Enable RFC 6587 framing by default on TCP input #5787

merged 5 commits into from
Apr 5, 2023

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Apr 4, 2023 •
edited
Loading

What does this PR do?

  • Enabled RFC 6587 framing by default on the TCP input, as PAN-OS devices will use this framing by default when TCP (and TLS) is used.
  • Added note in docs recommending that IETF format is used on PAN-OS and that RFC 6587 is enabled by default with TCP input
  • Remove non-compliant category from manifest

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/panw && elastic-package test

Related issues

@taylor-swanson
[panw] Enable RFC 6587 framing by default on TCP input
eb1da58 
- Enabled RFC 6587 framing by default on the TCP input, as PAN-OS devices
will use this framing by default when TCP (and TLS) is used.
- Added note in docs recommending that IETF format is used on PAN-OS and
that RFC 6587 is enabled by default with TCP input
@taylor-swanson taylor-swanson added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels Apr 4, 2023
@taylor-swanson taylor-swanson self-assigned this Apr 4, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-05T15:15:36.464+0000

  • Duration: 18 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 52
Skipped 0
Total 52

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (15/15) 💚
Classes 100.0% (15/15) 💚
Methods 98.551% (68/69) ❕
Lines 94.339% (3266/3462) ❕
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review April 4, 2023 13:42
@taylor-swanson taylor-swanson requested a review from a team as a code owner April 4, 2023 13:42
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson taylor-swanson merged commit 8a3df8b into elastic:main Apr 5, 2023
@taylor-swanson taylor-swanson deleted the issue/4511-panw-tcp-framing branch April 5, 2023 15:50
@elasticmachine
Copy link

Package panw - 3.7.0 containing this change is available at https://epr.elastic.co/search?package=panw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[panw] TCP syslog parsing fails because of rfc6587 framing
4 participants
@taylor-swanson @elasticmachine @andrewkroh @efd6