Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network_traffic: fix documentation for flows period #5779

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 4, 2023

What does this PR do?

This fixes documentation that misdirects users to use "-1" as a sentinel. This value causes packetbeat to fail to configure.

See https://github.com/elastic/beats/blob/25acf60399e2c56f544f4f76cb76611a28847cdf/packetbeat/flows/flows.go#L49-L66 and https://play.golang.com/p/Z7Si8WEzDAL.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:network_traffic Network Packet Capture docs labels Apr 4, 2023
@efd6 efd6 self-assigned this Apr 4, 2023
@efd6 efd6 force-pushed the 5771-network_traffic-docs branch from 86ea634 to 9ea29eb Compare April 4, 2023 01:22
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-05T22:18:59.918+0000

  • Duration: 71 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 173
Skipped 0
Total 173

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 71.875% (46/64)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review April 4, 2023 03:27
@efd6 efd6 requested a review from a team as a code owner April 4, 2023 03:27
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 force-pushed the 5771-network_traffic-docs branch from 9ea29eb to df7de32 Compare April 5, 2023 22:18
@efd6 efd6 merged commit 2ea5caa into elastic:main Apr 5, 2023
@elasticmachine
Copy link

Package network_traffic - 1.10.1 containing this change is available at https://epr.elastic.co/search?package=network_traffic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues docs Integration:network_traffic Network Packet Capture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants