-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][Hadoop] Migrate node_manager
and data_node
dashboards visualizations to lens in kibana 8.3.0
#5605
[O11y][Hadoop] Migrate node_manager
and data_node
dashboards visualizations to lens in kibana 8.3.0
#5605
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
packages/hadoop/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "0.5.0" | |||
changes: | |||
- description: Migrate `[Metrics Hadoop] Data nodes` and `[Metrics Hadoop] Node Manager` dashboard visualizations to lens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not needed to add [Metric Hadoop] string in the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks!
This name is already there in the current codebase. This is just the lens migration PR so we won't be changing any behavior as a part of this PR otherwise it will mess it up. However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately. |
As you think that the change will complicate the PR, continue with the same scope. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package hadoop - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=hadoop |
What does this PR do?
Migrate visualizations to lens for Hadoop integration package
Statistics for Hadoop Lens migration:
Checklist
changelog.yml
file.Author's checklist
Related issues