-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][WebSphere Application Server] Lens migration for visualizations to Kibana version 8.3.0 #5577
[O11y][WebSphere Application Server] Lens migration for visualizations to Kibana version 8.3.0 #5577
Conversation
🌐 Coverage report
|
@rajvi-elastic , Sharing a recommendation : to use colour theme as here The usage of themes / colours in a specific theme improve the UI consistency and also improve the dashboard readability |
Agreed @agithomas. The right color theme improves the dashboard readability and helps to highlight important data. But this PR only contains lens migration task and only three visualizations are migrated to new input controls. All the other panels are as it is. However, If you strongly feel that this change needs to be done then we can raise a separate issue for that and track them separately. |
Understood. Please stick to the current scope. |
Please create separate PRs for each dashboard / datastream. |
@agithomas I understand there are 29 file changes showing, but If you see there are only 179 lines that are changed and most of them are because we exported in 8.3.0 and hence some necessary default properties are added. FYI: Only 3 control panels are migrated to lens control panels, other visualizations are untouched as they were already in the lens. Let me know if you still want to raise the separate PR for each dashboard that contains 1 control panel change. |
It is difficult to review the PR in current form and hence i request you to split PR - one per dashboard. |
@agithomas, As per the recommendation, created 3 other PRs data-stream wise for WebSphere Application Server. For that reason we are declining this PR. Let me know if you have any issues. JDBC: #5631 |
Please complete the peer review of the new PRs |
What does this PR do?
Migrate visualizations to lens for WebSphere Application Server integration package
Statistics for WebSphere Application Server Lens migration:
Checklist
changelog.yml
file.Author's Checklist
Related issues