-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add third-party REST API #545
Conversation
687f5b7
to
a04e10d
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
a04e10d
to
cc7d8c2
Compare
d32aa06
to
faa2773
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like to see some tests that exercise the httpjson part of the config. This is the idea I had when I was thinking about how to test some other packages that use httpjson (like google workspace and okta): https://github.com/andrewkroh/stream/issues/9
ssl.verification_mode: {{ssl.verification_mode}} | ||
{{/if}} | ||
{{#if ssl.certificate_authorities}} | ||
ssl.certificate_authorites: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks misspelled.
packages/apache/manifest.yml
Outdated
title: Splunk REST API Password | ||
required: true | ||
show_user: true | ||
- name: ssl.enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few possible SSL options available. I suggest hiding the SSL options under an advanced setting and letting users configure it as YAML. Passing PEM encoded CA certs too is a little easier IMO with the textbox it gives you.
integrations/packages/zoom/data_stream/webhook/manifest.yml
Lines 40 to 50 in 8770467
- name: ssl | |
type: yaml | |
title: TLS | |
description: Options for enabling TLS for the listening webhook endpoint. Zoom requires webhooks listen on HTTPS. You must either provide a valid TLS certificate or use a reverse proxy in front of the integration. See the [documentation](https://www.elastic.co/guide/en/beats/filebeat/current/configuration-ssl.html) for a list of all options. | |
multi: false | |
required: false | |
show_user: false | |
default: | | |
enabled: false | |
certificate: "/etc/pki/client/cert.pem" | |
key: "/etc/pki/client/cert.key" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, see if the screenshot is what you were thinking
@@ -17,3 +17,29 @@ streams: | |||
template_path: log.yml.hbs | |||
title: Apache access logs | |||
description: Collect Apache access logs | |||
- input: httpjson | |||
title: Apache access logs via Splunk Enterprise REST API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably mark this with "(experimental)". Once we have a few more necessary package/fleet features we'll be able to implement this an independent package and remove these.
- apache - nginx - zeek - aws/cloudtrail
faa2773
to
ce66995
Compare
This reverts commit 399e8b0.
* Add third-party REST API - apache - nginx - zeek - aws/cloudtrail
What does this PR do?
Adds third-party REST API to several packages. This allows pulling data from Splunk REST API.
Checklist
Screenshots
Add Apache Integration Screen
Third-Party REST API Configuration
Example ingested document