Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system/auth: remove redundant regular expression quantifier #5320

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 19, 2023

What does this PR do?

Removes a redundant regular expression quantifier in the auth message grok processor.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:system System labels Feb 19, 2023
@efd6 efd6 self-assigned this Feb 19, 2023
@efd6 efd6 requested a review from a team February 19, 2023 21:52
@elasticmachine
Copy link

elasticmachine commented Feb 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-19T21:52:52.766+0000

  • Duration: 15 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 0
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 60.759% (48/79)
Lines 99.533% (2771/2784)
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review February 19, 2023 22:25
@efd6 efd6 requested a review from a team as a code owner February 19, 2023 22:25
@efd6 efd6 requested review from rdner and faec February 19, 2023 22:25
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 02df9e2 into elastic:main Feb 20, 2023
@elasticmachine
Copy link

Package system - 1.24.2 containing this change is available at https://epr.elastic.co/search?package=system

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@efd6 efd6 deleted the 5294-system branch February 5, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:system System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[system.auth] redundant wildcard in grok expression
3 participants