[System] Migrate dashboards to "by value" #5023
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| dynamic_fields: | ||
| "@timestamp": "^[0-9]{4}(-[0-9]{2}){2}T[0-9]{2}(:[0-9]{2}){2}\\.[0-9]{3}" | ||
|
Comment on lines
+1
to
+2
There was a problem hiding this comment. As suggested in #4950, added this dynamic field to fix tests due to timestamps: --- want
+++ got
@@ -1,7 +1,7 @@
{
"expected": [
{
- "@timestamp": "2022-05-21T21:54:44.000Z",
+ "@timestamp": "2023-05-21T21:54:44.000Z",
"ecs": {
"version": "8.0.0"
}, |
||
| fields: | ||
| event.timezone: "+0000" | ||
| multiline: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we normally tag versions here with
-next? Don't know if I've seen that on an integration before?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
-nextis added to the version, it is not published. This can be used to allow other PRs to be added without releasing.Here is a doc about it where it shows a possible use case: https://github.com/elastic/integrations/blob/main/docs/developer_workflow_design_build_test_integration.md#remember-to-bump-up-the-version
I set the version as this (without updating manifest.yml), so the package owner team can release this when they decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As talked to @jlind23 and @pierrehilbert about this versioning, I'll update the changelog entry and the manifest to be
1.21.0version. So once it is merged, it will be published.