[Kubernetes] Add data_stream.dataset pre filter is dashboards and remove duplicated dashboard tags #4972
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,6 @@ | |
| "panelsJSON": "{\"adf38acd-ecc8-48b2-b7f3-d6dfd024e46b\":{\"order\":0,\"width\":\"medium\",\"grow\":true,\"type\":\"optionsListControl\",\"explicitInput\":{\"fieldName\":\"orchestrator.cluster.name\",\"title\":\"Cluster Name\",\"id\":\"adf38acd-ecc8-48b2-b7f3-d6dfd024e46b\",\"enhancements\":{}}},\"3e873627-001d-47c7-91a8-995014b0ef90\":{\"order\":1,\"width\":\"medium\",\"grow\":true,\"type\":\"optionsListControl\",\"explicitInput\":{\"fieldName\":\"kubernetes.namespace\",\"title\":\"Namespace Name\",\"id\":\"3e873627-001d-47c7-91a8-995014b0ef90\",\"enhancements\":{}}},\"f4b8cf46-4644-4713-872d-dccc4aeb1e44\":{\"order\":2,\"width\":\"medium\",\"grow\":true,\"type\":\"optionsListControl\",\"explicitInput\":{\"fieldName\":\"kubernetes.cronjob.name\",\"title\":\"CronJob Name\",\"id\":\"f4b8cf46-4644-4713-872d-dccc4aeb1e44\",\"enhancements\":{}}}}" | ||
| }, | ||
| "description": "Metrics about Cronjobs", | ||
| "kibanaSavedObjectMeta": { | ||
| "searchSourceJSON": { | ||
| "filter": [], | ||
|
|
@@ -58,7 +57,7 @@ | |
| "panelIndex": "85ecbb8b-9606-4c19-a108-385f825ad7aa", | ||
| "title": "Kubernetes Dashboards [Metrics Kubernetes]", | ||
| "type": "visualization", | ||
| "version": "8.6.0-SNAPSHOT" | ||
| }, | ||
| { | ||
| "embeddableConfig": { | ||
|
|
@@ -87,7 +86,7 @@ | |
| "drop_last_bucket": 0, | ||
| "filter": { | ||
| "language": "kuery", | ||
| "query": "data_stream.dataset :\"kubernetes.state_cronjob\" " | ||
| }, | ||
| "id": "d9403a9e-99ec-469a-8373-8c33af18e310", | ||
| "index_pattern_ref_name": "metrics_37b56399-4cec-4d72-9e9e-e87cbe2d581f_0_index_pattern", | ||
|
|
@@ -144,6 +143,7 @@ | |
| "type": "metric", | ||
| "use_kibana_indexes": true | ||
| }, | ||
| "title": "", | ||
| "type": "metrics", | ||
| "uiState": {} | ||
| } | ||
|
|
@@ -158,31 +158,27 @@ | |
| "panelIndex": "37b56399-4cec-4d72-9e9e-e87cbe2d581f", | ||
| "title": "Active CronJobs [Metrics Kubernetes]", | ||
| "type": "visualization", | ||
| "version": "8.6.0-SNAPSHOT" | ||
| }, | ||
| { | ||
| "embeddableConfig": { | ||
| "attributes": { | ||
| "references": [ | ||
| { | ||
| "id": "metrics-*", | ||
| "name": "indexpattern-datasource-layer-7711169c-3a7b-4071-98d0-3644aa1dde0b", | ||
| "type": "index-pattern" | ||
| }, | ||
| { | ||
| "id": "metrics-*", | ||
| "name": "204eb33a-97ff-4d38-bee0-d93387164ab1", | ||
| "type": "index-pattern" | ||
| } | ||
| ], | ||
| "state": { | ||
| "adHocDataViews": {}, | ||
| "datasourceStates": { | ||
| "formBased": { | ||
| "layers": { | ||
| "7711169c-3a7b-4071-98d0-3644aa1dde0b": { | ||
| "columnOrder": [ | ||
|
|
@@ -283,21 +279,22 @@ | |
| "meta": { | ||
| "alias": null, | ||
| "disabled": false, | ||
| "index": "204eb33a-97ff-4d38-bee0-d93387164ab1", | ||
| "key": "data_stream.dataset", | ||
| "negate": false, | ||
| "params": { | ||
| "query": "kubernetes.state_cronjob" | ||
| }, | ||
| "type": "phrase" | ||
| }, | ||
| "query": { | ||
| "match_phrase": { | ||
| "data_stream.dataset": "kubernetes.state_cronjob" | ||
| } | ||
| } | ||
| } | ||
| ], | ||
| "internalReferences": [], | ||
| "query": { | ||
| "language": "kuery", | ||
| "query": "" | ||
|
|
@@ -327,6 +324,8 @@ | |
| "rowHeightLines": 1 | ||
| } | ||
| }, | ||
| "title": "CronJobs Informations [Metrics Kubernetes]", | ||
|
There was a problem hiding this comment. should we remove this from name not for this PR, in general There was a problem hiding this comment. Thanks for spotting those. In the statefulsets dashboard I missed to update one of the visualizations filters. There was a problem hiding this comment. after commit 43482cc Statefulset dashboard still use |
||
| "type": "lens", | ||
| "visualizationType": "lnsDatatable" | ||
| }, | ||
| "enhancements": {}, | ||
|
|
@@ -342,37 +341,33 @@ | |
| "panelIndex": "10f9719c-1b46-4561-b8cf-f3cd3ee69c10", | ||
| "title": "CronJobs Informations [Metrics Kubernetes]", | ||
| "type": "lens", | ||
| "version": "8.6.0-SNAPSHOT" | ||
| } | ||
| ], | ||
| "timeRestore": false, | ||
| "title": "[Metrics Kubernetes] Cronjobs", | ||
| "version": 1 | ||
| }, | ||
| "coreMigrationVersion": "8.6.0", | ||
| "created_at": "2023-01-11T14:16:01.140Z", | ||
| "id": "kubernetes-0a672d50-bcb1-11ec-b64f-7dd6e8e82013", | ||
| "migrationVersion": { | ||
| "dashboard": "8.6.0" | ||
| }, | ||
| "references": [ | ||
| { | ||
| "id": "metrics-*", | ||
| "name": "37b56399-4cec-4d72-9e9e-e87cbe2d581f:metrics_37b56399-4cec-4d72-9e9e-e87cbe2d581f_0_index_pattern", | ||
| "type": "index-pattern" | ||
| }, | ||
| { | ||
| "id": "metrics-*", | ||
| "name": "10f9719c-1b46-4561-b8cf-f3cd3ee69c10:indexpattern-datasource-layer-7711169c-3a7b-4071-98d0-3644aa1dde0b", | ||
| "type": "index-pattern" | ||
| }, | ||
| { | ||
| "id": "metrics-*", | ||
| "name": "10f9719c-1b46-4561-b8cf-f3cd3ee69c10:204eb33a-97ff-4d38-bee0-d93387164ab1", | ||
| "type": "index-pattern" | ||
| }, | ||
| { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there 2 different metrics-* index patterns? See line 173
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In references section there are five with the same id
metrics-*referenced. I don't know how so many got created. I will see if just one is okThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be the "data view as value" entries. If that is the case, I suspect there will be one per visualisations. I think that is one of the limitations @joshdover stumbled over recently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly. There Is one per visualizations are all needed for the dash to render
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to remove on of the two in this example but then I get errors in the visualization using it like
undefined is not an object (evaluating 't.find((({name:t})=>t===wc(e))).id'). So I will just keep as it isThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created this issue for Kibana team elastic/kibana#149105