Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka dashboard fix fields #4530

Merged
merged 8 commits into from
Dec 2, 2022

Conversation

lalit-satapathy
Copy link
Collaborator

@lalit-satapathy lalit-satapathy commented Nov 2, 2022

What does this PR do?

  • Fix kafka dashboard field names: kafka.topic.name & kafka.broker.id
  • Fix "kafka.consumergroup.partition -> kafka.partition.id"
  • Remove old field mappings which are already deleted from Beats not done in Integration code.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

  • Run the integration against a working kafka cluster.

Related issues

Screenshots

Updated dashboard after the field fix.
Integration Screenshot 2022-10-31 at 5 52 53 PM

@lalit-satapathy lalit-satapathy added bug Something isn't working, use only for issues Team:Service-Integrations Label for the Service Integrations team labels Nov 2, 2022
@lalit-satapathy lalit-satapathy self-assigned this Nov 2, 2022
@elasticmachine
Copy link

elasticmachine commented Nov 2, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-09T10:30:39.581+0000

  • Duration: 14 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 4, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.318
Classes 100.0% (1/1) 💚 2.318
Methods 72.222% (13/18) 👎 -18.818
Lines 77.778% (56/72) 👎 -13.926
Conditionals 100.0% (0/0) 💚

@lalit-satapathy lalit-satapathy marked this pull request as ready for review November 4, 2022 07:56
@lalit-satapathy lalit-satapathy requested a review from a team as a code owner November 4, 2022 07:56
- name: id
type: keyword
description: Consumer Group ID
- name: topic
type: keyword
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the issue looks like these are replaced by some other fields.
Eg: kafka.consumergroup.topic with kafka.topic.name.
Shouldn't that be added here instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is already there.

This PR only fixes, some of the remaining of the earlier changes.

Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lalit-satapathy lalit-satapathy merged commit 347df35 into elastic:main Dec 2, 2022
@elasticmachine
Copy link

Package kafka - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=kafka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix use of removed fields in Kafka dashboard in 8.x
3 participants