Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nginx ingress controller ipv6 #4140

Merged
merged 13 commits into from
Sep 7, 2022

Conversation

gsantoro
Copy link
Contributor

@gsantoro gsantoro commented Sep 6, 2022

What does this PR do?

  • Handle multiple upstream servers
  • Handle [] around IPv6 in upstream servers addresses

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

Author's Checklist

  • All pipeline tests are passing

How to test this PR locally

  • run elastic-package test pipeline -v from inside the nginx_ingress_controller package

Related issues

@gsantoro gsantoro added bug Something isn't working, use only for issues enhancement New feature or request labels Sep 6, 2022
@gsantoro gsantoro self-assigned this Sep 6, 2022
@gsantoro gsantoro requested a review from a team as a code owner September 6, 2022 08:57
@elasticmachine
Copy link

elasticmachine commented Sep 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-07T09:49:27.057+0000

  • Duration: 15 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.814
Classes 100.0% (2/2) 💚 2.814
Methods 100.0% (25/25) 💚 10.637
Lines 93.769% (316/337) 👍 2.442
Conditionals 100.0% (0/0) 💚

@gsantoro gsantoro requested a review from a team September 6, 2022 11:13
@gsantoro gsantoro merged commit 46822d4 into elastic:main Sep 7, 2022
@gsantoro gsantoro deleted the feature/nginx_ingress_controller_ipv6 branch September 7, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 address is not correctly parsed in nginx_ingress_controller integrations
4 participants