Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[journald] Add 8.x support #4037

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Aug 18, 2022

What does this PR do?

Update kibana.constraint to allow 8.1.0+. 8.1.0 is required because elastic/beats#30032
is needed due to a breaking change that was introduced in 8.0.0.

Rename message_id to ECS event.code. This field was added in 8.0. From man systemd.journal-fields

MESSAGE_ID=
A 128-bit message identifier ID for recognizing certain
message types, if this is desirable. ...

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Update kibana.constraint to allow 8.1.0+. 8.1.0 is required because elastic/beats#30032
is needed due to a breaking change that was introduced in 8.0.0.

Rename message_id to ECS event.code. This field was added in 8.0. From man systemd.journal-fields

  MESSAGE_ID=
           A 128-bit message identifier ID for recognizing certain
           message types, if this is desirable. ...
@andrewkroh andrewkroh force-pushed the journald/8x-support branch from 67a9f45 to 567448c Compare August 18, 2022 18:22
@andrewkroh andrewkroh marked this pull request as ready for review August 18, 2022 18:22
@andrewkroh andrewkroh requested a review from a team as a code owner August 18, 2022 18:22
@andrewkroh andrewkroh requested review from belimawr and rdner August 18, 2022 18:22
@andrewkroh andrewkroh added enhancement New feature or request Integration:journald Custom Journald logs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] labels Aug 18, 2022
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

elasticmachine commented Aug 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-18T18:22:49.324+0000

  • Duration: 12 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 1
Total 4

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.825
Classes 100.0% (0/0) 💚 2.825
Methods 75.0% (3/4) 👎 -14.336
Lines 100.0% (0/0) 💚 9.089
Conditionals 100.0% (0/0) 💚

Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:journald Custom Journald logs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants