-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES package log pipelines #4033
ES package log pipelines #4033
Conversation
🌐 Coverage report
|
packages/elasticsearch/data_stream/server/elasticsearch/ingest_pipeline/pipeline-json.yml
Show resolved
Hide resolved
packages/elasticsearch/data_stream/server/elasticsearch/ingest_pipeline/pipeline-json.yml
Show resolved
Hide resolved
packages/elasticsearch/data_stream/audit/elasticsearch/ingest_pipeline/pipeline-json.yml
Show resolved
Hide resolved
packages/elasticsearch/data_stream/deprecation/elasticsearch/ingest_pipeline/pipeline-json.yml
Show resolved
Hide resolved
@elastic/ecosystem I've added helper scripts to work with the package under the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts from visual inspection. Will give it a test run next.
@@ -0,0 +1,264 @@ | |||
status = error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tried minimizing this file? Basically I like to keep this sort of thing as short as possible so we can pick up on new defaults as new versions of ES come out rather than having to figure out what the "latest" file might be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, I'll look into it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a followup #4116
packages/elasticsearch/_dev/deploy/docker/scripts/generate-logs.sh
Outdated
Show resolved
Hide resolved
packages/elasticsearch/_dev/deploy/docker/scripts/generate-logs.sh
Outdated
Show resolved
Hide resolved
packages/elasticsearch/_dev/deploy/docker/scripts/install-package.sh
Outdated
Show resolved
Hide resolved
packages/elasticsearch/_dev/deploy/docker/scripts/install-package.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/elasticsearch/_dev/deploy/docker/scripts/install-package.sh
Outdated
Show resolved
Hide resolved
packages/elasticsearch/_dev/deploy/docker/scripts/install-package.sh
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mergable. Definitely some follow ups I could see but what's here works and it's nice to have a rough cut of the automation.
Closes #4046
Summary
Updates the log pipelines so we correctly ingest all elasticsearch log types.
Also adds a docker-compose with an elasticsearch service that can be started with
elastic-package service up
. The service is configured to generate logs out of the box, with an additional container continuously executing a script (generate-logs.sh
) that sends requests to ES to generate log types not created ootbTesting
cd packages/elasticsearch && elastic-package build
elastic-package stack up -v -d --version 8.5.0-SNAPSHOT
cd packages/elasticsearch && elastic-package service up -v
./packages/elasticsearch/_dev/deploy/docker/scripts/install-package.sh
,/tmp/service_logs/
.data_stream.dataset
forlogs-*
pattern in discover. Note that 4 log dataset should beelasticsearch.*
while deprecation is the other way arounddeprecation.elasticsearch
. Asked the ES team whether we should take the opportunity to reverse it in [elasticsearch] Verify logs mappings and pipelines #4046 (comment)These logs are also surfaced in the Stack Monitoring UI. You can connect a local kibana (from main) to the elastic-package stack (howto)