-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[elasticsearch] Align mappings with metricbeat #3928
Merged
klacabane
merged 9 commits into
elastic:main
from
klacabane:3914-fix-elasticsearch-mappings
Aug 4, 2022
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fe67816
align ecs fields
klacabane cc779c9
add index_stats property group
klacabane e74a67e
remove unused version index_recovery property
klacabane f7d56b2
align node_stats fields type
klacabane f4c3179
turn dynamic off for cluster_stats mappings
klacabane d17cf5c
bump kibana minimum version
klacabane 8ef350e
lint
klacabane bfec760
disable dynamic mappings for every data streams
klacabane f856c85
add missing shard property
klacabane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,24 @@ | ||
- external: ecs | ||
name: '@timestamp' | ||
- name: '@timestamp' | ||
external: ecs | ||
|
||
- name: ecs.version | ||
external: ecs | ||
|
||
- name: event.dataset | ||
external: ecs | ||
- name: event.duration | ||
external: ecs | ||
- name: event.module | ||
external: ecs | ||
|
||
- name: host.name | ||
external: ecs | ||
|
||
- name: service.address | ||
type: keyword | ||
description: Service address | ||
- name: service.type | ||
external: ecs | ||
- name: service.name | ||
external: ecs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
packages/elasticsearch/data_stream/cluster_stats/fields/ecs.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,24 @@ | ||
- name: '@timestamp' | ||
external: ecs | ||
|
||
- name: ecs.version | ||
external: ecs | ||
|
||
- name: event.dataset | ||
external: ecs | ||
- name: event.duration | ||
external: ecs | ||
- name: event.module | ||
external: ecs | ||
|
||
- name: host.name | ||
external: ecs | ||
|
||
- name: service.address | ||
type: keyword | ||
description: Service address | ||
- name: service.type | ||
external: ecs | ||
- name: service.name | ||
external: ecs | ||
|
4 changes: 4 additions & 0 deletions
4
packages/elasticsearch/data_stream/cluster_stats/manifest.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
packages/elasticsearch/data_stream/index_recovery/fields/ecs.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,24 @@ | ||
- name: '@timestamp' | ||
external: ecs | ||
|
||
- name: ecs.version | ||
external: ecs | ||
|
||
- name: event.dataset | ||
external: ecs | ||
- name: event.duration | ||
external: ecs | ||
- name: event.module | ||
external: ecs | ||
|
||
- name: host.name | ||
external: ecs | ||
|
||
- name: service.address | ||
type: keyword | ||
description: Service address | ||
- name: service.type | ||
external: ecs | ||
- name: service.name | ||
external: ecs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
packages/elasticsearch/data_stream/index_summary/fields/ecs.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,23 @@ | ||
- name: '@timestamp' | ||
level: core | ||
required: true | ||
type: date | ||
description: |- | ||
Date/time when the event originated. | ||
This is the date/time extracted from the event, typically representing when the event was generated by the source. | ||
If the event source has no original timestamp, this value is typically populated by the first time the event was received by the pipeline. | ||
Required field for all events. | ||
external: ecs | ||
|
||
- name: ecs.version | ||
external: ecs | ||
|
||
- name: event.dataset | ||
external: ecs | ||
- name: event.duration | ||
external: ecs | ||
- name: event.module | ||
external: ecs | ||
|
||
- name: host.name | ||
external: ecs | ||
|
||
- name: service.address | ||
type: keyword | ||
description: Service address | ||
- name: service.type | ||
external: ecs | ||
- name: service.name | ||
external: ecs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cluster_stats is the offending metricset that caused the initial issue in #3918 so I'd be inclined to close it at the same time, unless we want to review all metricsets and apply
dynamic: false
where necessaryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up disabling dynamic mappings on every data streams