Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] Move transit gateway lightweight module config into integration #3840

Merged
merged 7 commits into from
Jul 27, 2022
Merged

[AWS] Move transit gateway lightweight module config into integration #3840

merged 7 commits into from
Jul 27, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jul 26, 2022 •
edited
Loading

What does this PR do?

This PR is to move lightweight module configuration from Metricbeat into integrations for Transit Gateway.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@zmoog zmoog self-assigned this Jul 26, 2022
@zmoog zmoog added enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Jul 26, 2022
@elasticmachine
Copy link

elasticmachine commented Jul 26, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-27T21:49:03.096+0000

  • Duration: 39 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 346
Skipped 0
Total 346

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (11/11) 💚
Files 91.667% (11/12) 👎 -5.465
Classes 91.667% (11/12) 👎 -5.465
Methods 82.243% (176/214) 👎 -7.018
Lines 92.894% (2157/2322) 👍 2.299
Conditionals 100.0% (0/0) 💚

@zmoog zmoog force-pushed the lw-mods-transit-gateway branch from e4fedd8 to 1b0d487 Compare July 27, 2022 07:32
@zmoog zmoog marked this pull request as ready for review July 27, 2022 07:33
@zmoog zmoog requested a review from a team as a code owner July 27, 2022 07:33
tommyers-elastic
tommyers-elastic approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zmoog zmoog force-pushed the lw-mods-transit-gateway branch from 1b0d487 to e0b66d1 Compare July 27, 2022 10:02
kaiyan-sheng
kaiyan-sheng reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One nit: could you remove the '*.metrics.*.*' field from package-fields.yml please? since we list all the fields we are collecting in fields.yml, this '*.metrics.*.*' is not needed anymore.

@zmoog zmoog force-pushed the lw-mods-transit-gateway branch from e0b66d1 to 20f7a5a Compare July 27, 2022 21:38
zmoog added 6 commits July 27, 2022 23:43
@zmoog
Switch from lightweight module to cloudwatch
b07a91d
@zmoog
Update sample_event.json
aacfb59
@zmoog
Update version and changelog
f78cae1
@zmoog
Add missing fields BytesDropCount*
de8038f 
Add two missing metrics to the CloudWatch query:
- BytesDropCountNoRoute
- BytesDropCountBlackhole

The "[Metrics AWS] TransitGateway Overview" dashboard requires these two metrics to work correctly.
@zmoog
Update docs
9f37230
@zmoog
Remove unused fields mapping
326e307 
The mapping `*.metrics.*.*` is not needed anymore
@zmoog zmoog force-pushed the lw-mods-transit-gateway branch from cd3fa37 to 326e307 Compare July 27, 2022 21:45
@zmoog zmoog requested a review from kaiyan-sheng July 27, 2022 22:14
kaiyan-sheng
kaiyan-sheng approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!

@kaiyan-sheng kaiyan-sheng merged commit 972cfdc into elastic:main Jul 27, 2022
@zmoog zmoog deleted the lw-mods-transit-gateway branch July 27, 2022 23:10
@zmoog zmoog mentioned this pull request Aug 5, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@girodav girodav girodav approved these changes

@aspacca aspacca aspacca approved these changes

Assignees

@zmoog zmoog

Labels
enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lightweight modules from aws transitgateway data stream
6 participants
@zmoog @elasticmachine @aspacca @girodav @kaiyan-sheng @tommyers-elastic