Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ignore_older to remaining nginx and system data streams #3691

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Add ignore_older to remaining nginx and system data streams #3691

merged 2 commits into from
Jul 21, 2022

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Jul 12, 2022 •
edited
Loading

What does this PR do?

This closes #3147 and adds ignore_older fields for the remaining data streams in system, as well as nginx.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@fearful-symmetry fearful-symmetry added enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] labels Jul 12, 2022
@fearful-symmetry fearful-symmetry requested review from a team as code owners July 12, 2022 22:34
@fearful-symmetry fearful-symmetry self-assigned this Jul 12, 2022
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link

elasticmachine commented Jul 12, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T16:33:44.045+0000

  • Duration: 23 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 312
Skipped 0
Total 312

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 12, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 75.0% (6/8) ❕
Classes 75.0% (6/8) ❕
Methods 62.931% (73/116) ❕
Lines 95.765% (2917/3046) ❕
Conditionals 100.0% (0/0) 💚

@cmacknz
Copy link
Member

cmacknz commented Jul 13, 2022

Is ignore_older already available for the Windows integrations listed here? #3148

If not can you add those as well?

@cmacknz
Copy link
Member

cmacknz commented Jul 13, 2022

Looks like the windows integration was handled in 3a6e380

This was referenced Jul 18, 2022
Closed
Closed
@ManojS-shetty ManojS-shetty self-requested a review July 20, 2022 05:32
ManojS-shetty
ManojS-shetty reviewed Jul 20, 2022
View reviewed changes
packages/nginx/data_stream/access/manifest.yml
- name: ignore_older
type: text
title: Ignore events older than
default: 72h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason we are having 72h as a default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like at least a few other data streams set the same default, so I went with that.

@fearful-symmetry fearful-symmetry merged commit 9047592 into elastic:main Jul 21, 2022
@amolnater-qasource amolnater-qasource mentioned this pull request Aug 12, 2022
Closed
@andrewkroh andrewkroh mentioned this pull request Aug 25, 2022
Merged
@amolnater-qasource amolnater-qasource mentioned this pull request Aug 30, 2022
Closed
DJRickyB
DJRickyB reviewed Sep 15, 2022
View reviewed changes
packages/nginx/changelog.yml
changes:
- description: Add ignore_older to log data streams
type: enhancement
link: https://github.com/elastic/integrations/pull/3690
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by, because I happened to be looking, this is #3691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJRickyB DJRickyB DJRickyB left review comments

@ManojS-shetty ManojS-shetty ManojS-shetty approved these changes

@cmacknz cmacknz cmacknz approved these changes

@belimawr belimawr belimawr approved these changes

@leehinman leehinman Awaiting requested review from leehinman leehinman was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@fearful-symmetry fearful-symmetry

Labels
enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Meta] Implement input parameter ignore_older for all log inputs
6 participants
@fearful-symmetry @elasticmachine @cmacknz @belimawr @DJRickyB @ManojS-shetty