Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Metrics] Move container instance metrics from beats to integrations #3593

Merged
merged 5 commits into from
Jun 29, 2022
Merged

[Azure Metrics] Move container instance metrics from beats to integrations #3593

merged 5 commits into from
Jun 29, 2022

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jun 27, 2022 •
edited
Loading

What does this PR do?

This PR is to move lightweight module configuration from Metricbeat into integrations.

Checklist

  • I have reviewed tips for building integrations, and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related Issues

@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-28T13:03:25.606+0000

  • Duration: 13 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 131
Skipped 0
Total 131

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 27, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.409
Classes 100.0% (0/0) 💚 3.409
Methods 57.143% (16/28) 👎 -31.678
Lines 100.0% (0/0) 💚 10.064
Conditionals 100.0% (0/0) 💚

@zmoog zmoog self-assigned this Jun 28, 2022
@zmoog zmoog added Team:Cloud-Monitoring Label for the Cloud Monitoring team enhancement New feature or request labels Jun 28, 2022
@zmoog zmoog marked this pull request as ready for review June 28, 2022 13:02
@zmoog zmoog requested a review from a team as a code owner June 28, 2022 13:02
zmoog added 5 commits June 28, 2022 15:02
@zmoog
Move container instance metrics to integrations
53e7e96 
Switch from "container_instance" to "monitor" metricset and adding the
metrics configuration from beats.
@zmoog
Fix yaml indentation
03b3123 
The missing `values` attribute broke the query
@zmoog
Add ingest pipeline to set the expected field names
24e0827 
The metrics comes from the input as `azure.monitor.*` but the other
part of the integration (fields mapping, dashboards) expects the
`azure.container_instance.*` name.
@zmoog
Comments and cleanup
a1e65d9
@zmoog
Update changelog entry
779975f
@zmoog zmoog force-pushed the rm-lw-mods-az-container_instance branch from 1768660 to 779975f Compare June 28, 2022 13:03
girodav
girodav approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@girodav girodav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zmoog zmoog merged commit f1a33c3 into elastic:main Jun 29, 2022
@zmoog zmoog deleted the rm-lw-mods-az-container_instance branch June 29, 2022 13:07
@zmoog zmoog changed the title [Azure] Move container instance metrics from beats to integrations [Azure Metrics] Move container instance metrics from beats to integrations Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girodav girodav girodav approved these changes

Assignees

@zmoog zmoog

Labels
enhancement New feature or request Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove lightweight modules from azure_metrics container_instance data stream
3 participants
@zmoog @elasticmachine @girodav