Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rsa2elk packages fields and config #349

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Update rsa2elk packages fields and config #349

merged 4 commits into from
Oct 28, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Oct 28, 2020 •
edited
Loading

What does this PR do?

Updates the rsa2elk packages to fix some problems:

  • Missing ECS fields.
  • Set ECS version to 1.6
  • Use contains handlebars action to set publisher_pipeline.disable_host.

As a result the following packages are updated:

  • cisco to 0.7.0
  • fortinet to 0.5.0
  • juniper to 0.4.0
  • microsoft to 0.3.0

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all datasets collect metrics or logs.

@adriansr adriansr added bug Something isn't working, use only for issues Team:Security-External Integrations labels Oct 28, 2020
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@adriansr adriansr requested a review from leehinman October 28, 2020 09:49
@adriansr adriansr changed the title Update rsa2elk Update rsa2elk packages fields and config Oct 28, 2020
@adriansr adriansr requested a review from marc-gr October 28, 2020 09:49
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #349 updated]

  • Start Time: 2020-10-28T09:54:36.934+0000

  • Duration: 8 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

@adriansr adriansr merged commit 4cb174f into elastic:master Oct 28, 2020
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@adriansr
Update rsa2elk packages fields and config (elastic#349)
e633298 
Updates the rsa2elk packages to fix some problems:
- Missing ECS fields.
- Set ECS version to 1.6
- Use contains handlebars action to set publisher_pipeline.disable_host.

The resulting packages are:
- cisco 0.7.0
- fortinet 0.5.0
- juniper 0.4.0
- microsoft 0.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

@leehinman leehinman Awaiting requested review from leehinman

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

@andrewstucki andrewstucki Awaiting requested review from andrewstucki

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @marc-gr