[microsoft_sqlserver] Add performance DataStream

[ManojS-shetty]

What does this PR do?

This PR contributes the performance data stream for Microsoft sqlserver which fetches information from what’s commonly known as Performance Counters in MSSQL. Please refer for transaction_log data stream PR here transaction_log

MSSQL server integration developed using generic sql, as per the design doc

• Added a data stream (performance) under microsoft_sqlserver integration package
• Added data collection logic for the data streams.
• Added Fields metadata in the appropriate yaml files.
• Added dashboards and visualizations.
• Added System Testing.
• No Documentation added.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

• Install the MSSQL
• Go to Integration UI in Kibana
• Add the Microsoft SQL Server Integration
• Enroll the new elastic-agent
• In the asset -> Performance dashboard you should be able to see the default visualization.

Screenshots

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-06-14T05:22:46.315+0000

• Duration: 14 min 24 sec

Test stats 🧪

Test	Results
Failed	0
Passed	8
Skipped	0
Total	8

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[ManojS-shetty]

Lets make sure we always use vis by value: #3448

Done . Visualizations are now using by value.

[jsoriano]

Added some comments about fields definitions.

[elasticmachine]

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

[lalit-satapathy]

@ManojS-shetty @muthu-mps,
Do we have any changes pending or all the feedbacks are resolved now?

@ruflin @jsoriano @r00tu53r, tar-getting the merge of this PR, need your approval for the same.

[ManojS-shetty]

@ManojS-shetty @muthu-mps, Do we have any changes pending or all the feedbacks are resolved now?

@ruflin @jsoriano @r00tu53r, tar-getting the merge of this PR, need your approval for the same.

The changes are Done.

[jsoriano]

There are a couple of unaddressed comments.

[jsoriano]

Same comments as in #3395 (review)

It'd be nice to have some pipeline tests, but I am ok with adding them later.

And I would consider removing the query by now, taking into account that it will be easier to add it later, than to remove it.

[ManojS-shetty]

Same comments as in #3395 (review)

It'd be nice to have some pipeline tests, but I am ok with adding them later.

And I would consider removing the query by now, taking into account that it will be easier to add it later, than to remove it.

@jsoriano Removed Query field for now.

[ManojS-shetty]

Pinging @elastic/security-external-integrations for approval.

[efd6]

I'd like to see a pipeline test here.

[ManojS-shetty]

I'd like to see a pipeline test here.

Thank you for that suggestion , Yes we will be keeping the pipeline test in enhancement.