-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sophos] Various improvements and log samples from 18.5 #3127
Merged
andrewkroh
merged 25 commits into
elastic:main
from
andrewkroh:sophos/fix-field-names-uri-parts
Apr 21, 2022
Merged
[sophos] Various improvements and log samples from 18.5 #3127
andrewkroh
merged 25 commits into
elastic:main
from
andrewkroh:sophos/fix-field-names-uri-parts
Apr 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
bug
Something isn't working, use only for issues
enhancement
New feature or request
Team:Security-External Integrations
Integration:sophos
Sophos
labels
Apr 19, 2022
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
from
April 19, 2022 19:03
41584c6
to
ff17251
Compare
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
from
April 20, 2022 16:09
ff17251
to
d52441c
Compare
Sync fix from elastic/beats#25250.
Fix inconsistency in that only some keys were being lowercase. And the way it was done before was not good because it modified the event.original value.
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
from
April 20, 2022 16:30
d52441c
to
fdf6e8d
Compare
Set the event.code from the message ID (and remove sophos.xg.messageid). Set destination.domain from dstdomain in anti-virus log. Fix event.original handling. The original message was being modified by the pipeline. Now the raw message is stored in event.original without modification. Lower case network.transport as per ECS. Set event.reason from sophos.xg.reason (and remove sophos.xg.reason).
Sandstorm Set file.name for sandstorm events (there was a typo in the if condition). Set url.domain, destination.domain, and destination.ip for sandstorm web events. System Health Convert sophos.xg.collisions, sophos.xg.receiveddrops, and sophos.xg.transmitteddrops to float in _source. Wireless Protection Change sophos.xg.clients_conn_ssid to long in mapping.
Use dst_domainname to set destination.domain for Anti-Virus SMTP events. Use src_domainname to set source.domain for Anti-Virus SMTP events.
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
from
April 20, 2022 18:57
fdf6e8d
to
112e782
Compare
In 17.5 and earlier the sha1sum contained the sha1 checksum of the file being analyzed. In 18.0 and later the sha1sum contains the sha256 checksum of the file.
Use the URL scheme to derive the protocol.
This was a large amount of duplication causing increased event sizes.
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
from
April 20, 2022 19:10
112e782
to
2bcd82c
Compare
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
from
April 20, 2022 19:49
2bcd82c
to
ebe5cfd
Compare
andrewkroh
changed the title
[sophos] Lowercase names, Add uri_parts, Fix trans_src_ip
[sophos] Various improvements and log samples from 18.5
Apr 20, 2022
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
2 times, most recently
from
April 20, 2022 20:13
da09ecf
to
a11cd4b
Compare
[git-generate] cd packages/sophos elastic-package format elastic-package build elastic-package test pipeline -g
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
from
April 20, 2022 21:16
a11cd4b
to
8216183
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
approved these changes
Apr 20, 2022
packages/sophos/data_stream/xg/elasticsearch/ingest_pipeline/sandstorm.yml
Outdated
Show resolved
Hide resolved
Replaces `ctx?.` with `ctx.` in all of the sophos.xg pipelines.
andrewkroh
force-pushed
the
sophos/fix-field-names-uri-parts
branch
from
April 21, 2022 15:52
fbd17f1
to
ab1fe1c
Compare
This was referenced Apr 21, 2022
v1v
added a commit
to v1v/integrations
that referenced
this pull request
Apr 25, 2022
…ations into feature/labels-cloud-ephemeral-components * 'feature/labels-cloud-ephemeral-components' of github.com:v1v/integrations: (23 commits) use branch standardise labels/tags Update .ci/Jenkinsfile [ci][terraform][aws] tags with metadata Bump github.com/elastic/elastic-package from 0.46.0 to 0.47.0 (elastic#3182) Spring boot package [Memory - data stream] (elastic#2979) [cisco_ise] Add Cisco ISE package (elastic#2855) [apache_spark][executor] Add Apache Spark package with Executor data stream (elastic#2943) [apache_spark][driver] Add Apache Spark package with Driver data stream (elastic#2945) cisco_duo: simplify grok expression for handling ports (elastic#3170) cisco_duo: fix handling of IP addresses with port numbers (elastic#3117) [sophos] Various improvements and log samples from 18.5 (elastic#3127) [cisco_asa] fix visualizations (elastic#3146) [apache_spark][application] Add Apache Spark package with Application data stream (elastic#2941) Fix pagination bug that skipped events when more than one page is present. (elastic#3140) Cis k8s name migration (elastic#3113) remove exported fields; these will be added to Kibana docs instead (elastic#3093) Exclude ecosystem as owner of subdirectories of packages (elastic#3132) [awsfargate] bump package version (elastic#3130) add first csp rule template (elastic#3081) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working, use only for issues
enhancement
New feature or request
Integration:sophos
Sophos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove space from sophos.xg.trans_src_ip field name in mapping. Sync fix from [Filebeat] Remove space from field
sophos.xg.trans_src_ ip
beats#25250.Do not modify event.original.
Populate
url.*
fields based onsophos.xg.url
.Rename
sophos.xg.reason
toevent.reason
(ECS).Normalize all
sophos.xg.*
keys to lowercase.Lowercase
network.transport
as per ECS.Format
source.mac
anddestination.mac
as per ECS.Add Sophos Firewall 18.5 log samples taken from documentation.
Set the
event.code
from the message ID (and removesophos.xg.messageid
).Consolidate geoip enrichment
Consolidate related.ip processors
Consolidate lowercase network.transport/protocol
Consolidate related.user processing
Consolidate related.hash
Consolidate network.{bytes,packets} calculations
Add network.community_id
Add {url,source,destination}.domain to related.hosts
Set event.duration (ns) for WAF events using reponsetime (us)
Remove client/server mappings. This was a large amount of duplication causing increased event sizes.
Add reference link to xg syslog formats
Anti-Virus
Set
destination.domain
fromsophos.xg.dstdomain
in anti-virus log.Use
sophos.xg.dst_domainname
to setdestination.domain
for Anti-Virus SMTP events.Use
sophos.xg.src_domainname
to setsource.domain
for Anti-Virus SMTP events.Set
network.protocol
for anti-virus logs.Anti-Spam
network.protocol
for anti-spam logs.Content Filtering
network.protocol
for Content Filtering. Use the URL scheme to derive the protocol.Sandstorm
Set
file.name
for Sandstorm events (there was a typo in the if condition).Set
url.domain
,destination.domain
, anddestination.ip
for Sandstorm web events.Handle sha256 Sandstorm file hashes. In 17.5 and earlier the sha1sum contained the sha1 checksum of the file being analyzed. In 18.0 and later the sha1sum contains the sha256 checksum of the file.
System Health
sophos.xg.collisions
,sophos.xg.receiveddrops
, andsophos.xg.transmitteddrops
to float in document_source
.Wireless Protection
sophos.xg.clients_conn_ssid
to a long in the mapping.Checklist
changelog.yml
file.