Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional fields from V2 ALB logs #304

Merged
merged 8 commits into from
Oct 12, 2020
Merged

Add support for additional fields from V2 ALB logs #304

merged 8 commits into from
Oct 12, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to add support for additional fields from V2 ALB logs into integrations.
PR in Beats: elastic/beats#21540

@elasticmachine
Copy link

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link

elasticmachine commented Oct 7, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #304 updated]

  • Start Time: 2020-10-12T17:39:50.894+0000

  • Duration: 8 min 1 sec

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaiyan-sheng
Copy link
Contributor Author

kaiyan-sheng commented Oct 8, 2020

Help help 🙂 @mtojek CI failed with the same error I got when I tried to run elastic-package test pipeline locally:

+        },
+        {
+            "message": "",
+            "error": {
+                "message": "Provided Grok expressions do not match field value: []"
+            }
         }
     ]
 }

@mtojek
Copy link
Contributor

mtojek commented Oct 12, 2020

Good finding :) I've finished the investigation. It' a bug in elastic-package. As a temporary workaround you can use the following config:

{
  "multiline": {
    "first_line_pattern": "^http"
  }
}

but I will work on the workaround today and post the update here.

@mtojek
Copy link
Contributor

mtojek commented Oct 12, 2020

@ycombinator that's a weird HTTP error during system tests:

[2020-10-12T15:49:03.131Z] Error: error running package system tests: could not add data stream config to policy: could not add package to policy; API status code = 502; response body = {"statusCode":502,"error":"Bad Gateway","message":"'404 Not Found' error response from package registry at https://epr.elastic.co/package/apache/0.2.4/"}

EDIT:

not sure why is it using production endpoint.

@mtojek
Copy link
Contributor

mtojek commented Oct 12, 2020

jenkins run the tests please

@kaiyan-sheng
Copy link
Contributor Author

Merging, CI is happy now.

@kaiyan-sheng kaiyan-sheng merged commit 7d2273d into elastic:master Oct 12, 2020
@kaiyan-sheng kaiyan-sheng deleted the alb branch October 12, 2020 18:20
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants