Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apache spark] Add visualizations and dashboard #3020

Merged
merged 5 commits into from
May 9, 2022

Conversation

yug-rajani
Copy link
Contributor

@yug-rajani yug-rajani commented Apr 6, 2022

  • Enhancement

What does this PR do?

This PR adds dashboard for apache-spark integration package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/apache_spark directory.
  • Run the following command to run tests.
    elastic-package test

Related issues

Screenshots

Dashboard Screenshot

@yug-rajani yug-rajani requested a review from mtojek April 6, 2022 20:40
@elasticmachine
Copy link

elasticmachine commented Apr 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-09T07:29:48.682+0000

  • Duration: 17 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 33
Skipped 0
Total 33

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@yug-rajani yug-rajani marked this pull request as ready for review April 12, 2022 10:01
@yug-rajani yug-rajani requested a review from a team as a code owner April 12, 2022 10:01
@yug-rajani yug-rajani self-assigned this Apr 18, 2022
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can share the high-level feedback.

  • There are too many counters compared to standard graphs. You don't need to put every metrics on a dashboard
  • I suggest showing:
    • counters: executors, jobs, stages, workers
    • graphs: stages, tasks, memory usage, read write bytes
    • gauges: cores
  • Please simulate some tough Spark processing, so dashboards don't contain only zeros and flat lines.

@yug-rajani yug-rajani added enhancement New feature or request Team:Integrations Label for the Integrations team Integration:apache_spark Apache Spark labels Apr 22, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@yug-rajani
Copy link
Contributor Author

Thanks for the feedback, @mtojek!
We have incorporated the changes. Please take a look at your convenience.

@yug-rajani yug-rajani requested a review from mtojek April 22, 2022 12:48
@yug-rajani yug-rajani linked an issue Apr 26, 2022 that may be closed by this pull request
16 tasks
@elasticmachine
Copy link

elasticmachine commented May 3, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.676
Classes 100.0% (0/0) 💚 3.676
Methods 75.0% (12/16) 👎 -13.786
Lines 100.0% (0/0) 💚 10.026
Conditionals 100.0% (0/0) 💚

@mtojek mtojek self-requested a review May 9, 2022 08:09
@mtojek mtojek merged commit 9d2ab13 into elastic:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:apache_spark Apache Spark Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Apache Spark integration
3 participants