[nagios_xi] Add Nagios package with Service data stream #2944

kush-elastic · 2022-03-30T18:04:40Z

Enhancement

What does this PR do?

Generated the skeleton of Nagios integration package.
Added 1 data stream (Service).
Added data collection logic for the data streams.
Added the ingest pipeline for the data streams.
Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
Added dashboards and visualizations.
Added system test cases for the data stream.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone integrations repo.
Install elastic-package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/nagios_xi directory.
Run the following command to run tests.
elastic-package test

Related issues

Relates Create Nagios Integration #2626

Screenshots

elasticmachine · 2022-03-30T18:17:50Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-05-03T02:18:41.805+0000
Duration: 16 min 20 sec

Test stats 🧪

Test	Results
Failed	0
Passed	15
Skipped	0
Total	15

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

kush-elastic · 2022-03-30T19:18:29Z

packages/nagios_xi/manifest.yml

+  - monitoring
+release: beta
+conditions:
+  kibana.version: ^8.0.0


This will be updated with 8.2.0 after testing this integration on 8.2.0.

elasticmachine · 2022-03-30T19:23:18Z

Pinging @elastic/integrations (Team:Integrations)

mtojek · 2022-03-31T10:10:56Z

packages/nagios_xi/changelog.yml

+  changes:
+    - description: Nagios integration package with Logs, Host and Service metrics
+      type: enhancement
+      link: https://github.com/elastic/integrations/pull/2824


nit: you have to update the PR link reference to point to this review.

packages/nagios_xi/docs/README.md

mtojek · 2022-03-31T10:13:58Z

packages/nagios_xi/data_stream/service/fields/fields.yml

+- name: nagios_xi
+  type: group
+  fields:
+    - name: service


Does it contain the same fields as for the host data stream?

Not all the fields are same, but there are some common fields.

I didn't check precisely the percentage of different fields, but maybe it's better to keep it as a single data stream. WDYT @ruflin ?

The decision if one or multiple data streams should be less driven by how many fields are different then how users are going to consume it. Will some users only want to collect service or host? Will there be different retention periods?

There are groups based on hosts and services.
If we consider merging host and service data-streams in one, user will get confused.
Services depends on hosts so same type of service can be collected from different hosts.

Another reason is, we have different endpoints for hosts and services. means we need two httpjson input.
And as we know we don't have a way to use multiple input in single data_stream.

Thanks for the details @kush-elastic Based on this information I would go for 2 data streams for now. It is easier to merge 2 into one later on then the other way around I think.

mtojek · 2022-04-06T09:17:07Z

packages/nagios_xi/data_stream/service/_dev/test/pipeline/test-service.log-expected.json

@@ -334,7 +334,7 @@
                    "check_type": "0",
                    "current_check_attempt": "1",
                    "current_notification_number": "0",
-                    "current_state": "0",
+                    "current_state": "Up/Pending",


lalit-satapathy · 2022-04-07T11:27:56Z

packages/nagios_xi/data_stream/service/sample_event.json

+            "failure_prediction_enabled": "0",
+            "flap_detection_enabled": "0",
+            "has_been_checked": "1",
+            "host_address": "www.nagios.org",


How these host* fields under the "service" metrics. Should these be part of core ECS host* fields. I am not sure, Checking with @mtojek

Hey @lalit-satapathy,
In Nagios XI, There are groups based on hosts and services. and each services have again on specific hosts. so user will get confused if we show host name in both host and service data-stream. if we have different fields here user will be able to identify it much better.
Here services runs on specific hosts.
What do you think?

elasticmachine · 2022-05-03T02:35:12Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`3/3`)	💚
Files	100.0% (`3/3`)	💚 3.21
Classes	100.0% (`3/3`)	💚 3.21
Methods	97.059% (`33/34`)	👍 8.779
Lines	96.684% (`1137/1176`)	👍 7.784
Conditionals	100.0% (`0/0`)	💚

Add service data-stream

6536263

kush-elastic requested a review from a team as a code owner March 30, 2022 18:04

kush-elastic commented Mar 30, 2022

View reviewed changes

kush-elastic requested a review from mtojek March 30, 2022 19:19

kush-elastic self-assigned this Mar 30, 2022

kush-elastic added enhancement New feature or request Team:Integrations Label for the Integrations team New Integration Issue or pull request for creating a new integration package. labels Mar 30, 2022

kush-elastic mentioned this pull request Mar 31, 2022

[nagios] Add Nagios package #2824

Closed

4 tasks

kush-elastic marked this pull request as draft March 31, 2022 09:06

mtojek reviewed Mar 31, 2022

View reviewed changes

kush-elastic added 2 commits March 31, 2022 20:05

nits

42df1e1

Add Service desc

c6a2204

kush-elastic requested a review from mtojek April 1, 2022 04:55

mtojek approved these changes Apr 1, 2022

View reviewed changes

Resolve Conflict

f830698

kush-elastic marked this pull request as ready for review April 5, 2022 11:58

kush-elastic requested a review from a team as a code owner April 5, 2022 11:58

kush-elastic requested review from mtojek and ruflin April 5, 2022 12:28

kush-elastic added 3 commits April 5, 2022 18:19

Remove screenshot

5e2b405

Update ingest pipeline

3327e13

Update readme file

3f7093b

mtojek approved these changes Apr 6, 2022

View reviewed changes

andrewkroh added the Integration:nagios_xi Nagios XI label Apr 6, 2022

kush-elastic changed the title ~~[nagios] Add Nagios package with Service data stream~~ [nagios_xi] Add Nagios package with Service data stream Apr 7, 2022

lalit-satapathy reviewed Apr 7, 2022

View reviewed changes

update event.kind: metric

b0f659d

update readme

720376b

kush-elastic requested a review from lalit-satapathy May 5, 2022 11:54

mtojek merged commit f3e5415 into elastic:main May 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[nagios_xi] Add Nagios package with Service data stream #2944

[nagios_xi] Add Nagios package with Service data stream #2944

kush-elastic commented Mar 30, 2022

elasticmachine commented Mar 30, 2022 •

edited

Loading

Build stats

Test stats 🧪

kush-elastic Mar 30, 2022

elasticmachine commented Mar 30, 2022

mtojek Mar 31, 2022

kush-elastic Mar 31, 2022

mtojek Mar 31, 2022

kush-elastic Mar 31, 2022

mtojek Mar 31, 2022

ruflin Apr 1, 2022

kush-elastic Apr 1, 2022 •

edited

Loading

ruflin Apr 1, 2022

mtojek Apr 6, 2022

lalit-satapathy Apr 7, 2022

kush-elastic May 4, 2022

elasticmachine commented May 3, 2022

[nagios_xi] Add Nagios package with Service data stream #2944

[nagios_xi] Add Nagios package with Service data stream #2944

Conversation

kush-elastic commented Mar 30, 2022

What does this PR do?

Checklist

How to test this PR locally

Related issues

Screenshots

elasticmachine commented Mar 30, 2022 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

Choose a reason for hiding this comment

elasticmachine commented Mar 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kush-elastic Apr 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented May 3, 2022

🌐 Coverage report

elasticmachine commented Mar 30, 2022 •

edited

Loading

kush-elastic Apr 1, 2022 •

edited

Loading