Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ecs.version to elastic_agent fields #2844

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Add ecs.version to elastic_agent fields #2844

merged 3 commits into from
Mar 18, 2022

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Mar 17, 2022 •
edited
Loading

What does this PR do?

Fixes the missing ecs.version fields on the elastic_agent package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Run elastic-package build
  2. Run elastic-package stack up
  3. Go to Discover and within the logs-* data view, type ecs.version: "8.0.0" into the filter bar
  4. Verify that logs from elastic_agent are shown

Related issues

Screenshots

image

@elasticmachine
Copy link

elasticmachine commented Mar 17, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-18T12:46:26.486+0000

  • Duration: 12 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@joshdover joshdover added bug Something isn't working, use only for issues Team:Fleet Label for the Fleet team [elastic/fleet] Integration:elastic_agent Elastic Agent labels Mar 18, 2022
@joshdover joshdover marked this pull request as ready for review March 18, 2022 12:04
@joshdover joshdover requested a review from a team as a code owner March 18, 2022 12:04
@elasticmachine
Copy link

Pinging @elastic/fleet (Team:Fleet)

@joshdover joshdover marked this pull request as draft March 18, 2022 12:13
@joshdover
Copy link
Contributor Author

Hold on, didn't quite do this right

@joshdover joshdover changed the title Fix elastic_agent ecs fields Add ecs.version to elastic_agent fields Mar 18, 2022
@joshdover joshdover marked this pull request as ready for review March 18, 2022 12:19
@ruflin
Copy link
Contributor

ruflin commented Mar 18, 2022

I already approved but now wonder why you only picked the logs dataset?

@joshdover
Copy link
Contributor Author

I already approved but now wonder why you only picked the logs dataset?

Fixed, good catch

@joshdover joshdover merged commit 1d18f55 into elastic:main Mar 18, 2022
@joshdover joshdover deleted the fx-ea-ecs branch March 18, 2022 15:18
@joshdover joshdover mentioned this pull request Mar 21, 2022
Merged
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@joshdover
Add ecs.version to elastic_agent fields (elastic#2844)
6a76864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@ph ph ph approved these changes

Assignees
No one assigned
Labels
bug Something isn't working, use only for issues Integration:elastic_agent Elastic Agent Team:Fleet Label for the Fleet team [elastic/fleet]
Projects
None yet
Milestone
No milestone
4 participants
@joshdover @elasticmachine @ruflin @ph